Re: RFR: 8245194: Unix domain socket channel implementation [v7]

2020-09-24 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to

Re: RFR: 8245194: Unix domain socket channel implementation [v6]

2020-09-24 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to

Re: RFR: 8245194: Unix domain socket channel implementation [v5]

2020-09-21 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to

Re: RFR: 8245194: Unix domain socket channel implementation [v4]

2020-09-14 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to

Re: RFR: 8245194: Unix domain socket channel implementation [v3]

2020-09-14 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to

Re: RFR: 8245194: Unix domain socket channel implementation

2020-09-11 Thread Michael McMahon
On Mon, 7 Sep 2020 12:05:07 GMT, Michael McMahon wrote: > Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote:

Re: RFR: 8245194: Unix domain socket channel implementation [v2]

2020-09-11 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to

RFR: 8245194: Unix domain socket channel implementation

2020-09-07 Thread Michael McMahon
Continuing this review as a PR on github with the comments below incorporated. I expect there will be a few more iterations before integrating. On 06/09/2020 19:47, Alan Bateman wrote: > On 26/08/2020 15:24, Michael McMahon wrote: >> >> As I mentioned the other day, I wasn't able to use the