Hi Paul,
On 2020-05-29 21:57, Paul Sandoz wrote:
This looks good.
Thanks for reviewing!
204 String recipe = "\u0001".repeat(concatType.parameterCount());
IIUC, that’s a rather convoluted way of creating a List from:
Collections.nCopies(concatType.parameterCount(). (String)
On 2020-05-29 21:18, fo...@univ-mlv.fr wrote:
- Mail original -
De: "Claes Redestad"
À: "Remi Forax"
Cc: "core-libs-dev"
Envoyé: Vendredi 29 Mai 2020 20:45:26
Objet: Re: RFR: 8246152: Improve String concat bootstrapping
On 2020-05-29
This looks good.
204 String recipe = "\u0001".repeat(concatType.parameterCount());
IIUC, that’s a rather convoluted way of creating a List from:
Collections.nCopies(concatType.parameterCount(). (String) null);
Perhaps it makes sense to double down on the List representation with an
- Mail original -
> De: "Claes Redestad"
> À: "Remi Forax"
> Cc: "core-libs-dev"
> Envoyé: Vendredi 29 Mai 2020 20:45:26
> Objet: Re: RFR: 8246152: Improve String concat bootstrapping
> On 2020-05-29 19:32, fo...@univ-mlv.fr wr
On 2020-05-29 19:32, fo...@univ-mlv.fr wrote:
- Mail original -
De: "Claes Redestad"
À: "Remi Forax"
Cc: "core-libs-dev"
Envoyé: Vendredi 29 Mai 2020 18:47:03
Objet: Re: RFR: 8246152: Improve String concat bootstrapping
Hi Rémi,
thanks for looki
- Mail original -
> De: "Claes Redestad"
> À: "Remi Forax"
> Cc: "core-libs-dev"
> Envoyé: Vendredi 29 Mai 2020 18:47:03
> Objet: Re: RFR: 8246152: Improve String concat bootstrapping
> Hi Rémi,
>
> thanks for looking at this and
Hi Rémi,
thanks for looking at this and suggesting some improvements!
On 2020-05-29 17:51, Remi Forax wrote:
Hi Claes,
For the code below the comment "Mock the recipe to reuse the concat generator
code",
i believe you can use String.repeat() that was introduced recently.
Sure,
The code
- Mail original -
> De: "Claes Redestad"
> À: "Remi Forax"
> Cc: "core-libs-dev"
> Envoyé: Vendredi 29 Mai 2020 18:10:40
> Objet: Re: RFR: 8246152: Improve String concat bootstrapping
> Hi,
>
> will deal with your suggestions soon
Hi,
will deal with your suggestions soon, separately. :-)
On 2020-05-29 17:51, Remi Forax wrote:
Can you explain me, what rebind is exactly ?
MH.rebind() wraps any kind of MH as a BoundMethodHandle, which
is necessary to subject it to transforms.
/** Require this method handle to be a
yWithSuffix
Can you explain me, what rebind is exactly ?
Rémi
- Mail original -
> De: "Claes Redestad"
> À: "core-libs-dev"
> Envoyé: Vendredi 29 Mai 2020 17:05:19
> Objet: RFR: 8246152: Improve String concat bootstrapping
> Hi,
>
> a few s
Hi,
a few small simplifications and optimizations to StringConcatFactory:
- refactor makeConcat/makeConcatWithArguments methods to remove the
generateRecipe argument
- fold back-to-back constants into one when parsing recipe, which
allows the prepender logic to be simplified
- do input
11 matches
Mail list logo
