Re: RFR: 8246451: Reduce overhead of normalizing file paths with trailing slash

2020-06-03 Thread Claes Redestad
On 2020-06-03 16:24, Lance Andersen wrote: Hi Claes, This looks OK :-) Thank you, Lance! /Claes Best Lance On Jun 3, 2020, at 7:54 AM, Claes Redestad > wrote: Hi, I'd like to fix a bug in the microbenchmark I pushed for JDK-8246338 where the FileOpen.t

Re: RFR: 8246451: Reduce overhead of normalizing file paths with trailing slash

2020-06-03 Thread Lance Andersen
Hi Claes, This looks OK :-) Best Lance > On Jun 3, 2020, at 7:54 AM, Claes Redestad wrote: > > Hi, > > I'd like to fix a bug in the microbenchmark I pushed for JDK-8246338 > where the FileOpen.trailingSlash variant doesn't do what it intends to. > > There's also a profitable low-hanging opti

RFR: 8246451: Reduce overhead of normalizing file paths with trailing slash

2020-06-03 Thread Claes Redestad
Hi, I'd like to fix a bug in the microbenchmark I pushed for JDK-8246338 where the FileOpen.trailingSlash variant doesn't do what it intends to. There's also a profitable low-hanging optimization down that path to substring rather than take the detour via StringBuilder[1] Bug:https://bugs.o