Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v4]

> Please review this modification of `java.io.InputStream.skipNBytes(long)` to > improve its performance when `skip(long)` skips fewer than the requested > number of bytes. In the current implementation, `skip(long)` is invoked once > and, if not enough bytes have been skipped, then `read()` is

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v3]

> Please review this modification of `java.io.InputStream.skipNBytes(long)` to > improve its performance when `skip(long)` skips fewer than the requested > number of bytes. In the current implementation, `skip(long)` is invoked once > and, if not enough bytes have been skipped, then `read()` is

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

On Fri, 20 Nov 2020 11:43:11 GMT, sergus13 wrote: >> Brian Burkhalter has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8246739: InputStream.skipNBytes could be implemented more efficiently >> - 8246739: InputStream.skipNBytes could

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

On Fri, 20 Nov 2020 09:56:16 GMT, sergus13 wrote: >> Brian Burkhalter has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8246739: InputStream.skipNBytes could be implemented more efficiently >> - 8246739: InputStream.skipNBytes could

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

On Thu, 19 Nov 2020 21:41:00 GMT, Naoto Sato wrote: >> Brian Burkhalter has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8246739: InputStream.skipNBytes could be implemented more efficiently >> - 8246739: InputStream.skipNBytes could

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently

> On Nov 19, 2020, at 12:04 PM, Brian Burkhalter wrote: > > On Thu, 19 Nov 2020 19:58:16 GMT, Naoto Sato > wrote: > >> The code looks good. Should we also change the @implSpec, as it specifically >> describes how it works, i.e., calling no-arg read(), but the new

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]

> Please review this modification of `java.io.InputStream.skipNBytes(long)` to > improve its performance when `skip(long)` skips fewer than the requested > number of bytes. In the current implementation, `skip(long)` is invoked once > and, if not enough bytes have been skipped, then `read()` is

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently

On Thu, 19 Nov 2020 19:58:16 GMT, Naoto Sato wrote: > The code looks good. Should we also change the @implSpec, as it specifically > describes how it works, i.e., calling no-arg read(), but the new impl calls > read() with buffer. Good catch. Yes, the `@implSpec` should be updated. I was too

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently

On Thu, 19 Nov 2020 19:29:43 GMT, Brian Burkhalter wrote: > Please review this modification of `java.io.InputStream.skipNBytes(long)` to > improve its performance when `skip(long)` skips fewer than the requested > number of bytes. In the current implementation, `skip(long)` is invoked once >

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently

On Thu, 19 Nov 2020 19:52:05 GMT, Sergey Bylokhov wrote: >> Please review this modification of `java.io.InputStream.skipNBytes(long)` to >> improve its performance when `skip(long)` skips fewer than the requested >> number of bytes. In the current implementation, `skip(long)` is invoked once

Re: RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently

On Thu, 19 Nov 2020 19:29:43 GMT, Brian Burkhalter wrote: > Please review this modification of `java.io.InputStream.skipNBytes(long)` to > improve its performance when `skip(long)` skips fewer than the requested > number of bytes. In the current implementation, `skip(long)` is invoked once >

RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently

Please review this modification of `java.io.InputStream.skipNBytes(long)` to improve its performance when `skip(long)` skips fewer than the requested number of bytes. In the current implementation, `skip(long)` is invoked once and, if not enough bytes have been skipped, then `read()` is invoked