On Wed, 2 Dec 2020 12:11:16 GMT, Jan Lahoda wrote:
>> Yes, would be a surprise if getPermittedSubclasses returned Class objects
>> for classes that are not subclasses. I think it should be okay to separate
>> that out to a separate issue so that it can be further re-examined after JEP
>> 397
On Wed, 2 Dec 2020 12:08:09 GMT, Alan Bateman wrote:
>> @lahodaj It is okay with me if `getPermittedSubclasses` returns the
>> permitted subtypes matching the runtime view (that matches the current
>> specification to me) and revisit this API as a follow up.
>
> Yes, would be a surprise if
On Tue, 1 Dec 2020 23:19:41 GMT, Mandy Chung wrote:
>> I was investigating a little today. One thing to note is that there is a
>> difference between the JLS and JVMS[1] restrictions - the JVMS restrictions
>> only require the classes to be in the same module, but they can be in any
>>
On Tue, 1 Dec 2020 16:49:03 GMT, Jan Lahoda wrote:
>> So it could also return a class listed in `PermittedSubclasses` attribute
>> but not a subclass of this sealed class, right?
>>
>> The specification of `Class::getPermittedSubclasses` says:
>>
>>> Returns an array containing {@code Class}
On Tue, 1 Dec 2020 00:36:54 GMT, Mandy Chung wrote:
>> The JVM method that returns the permitted subclasses (and interfaces) does
>> not weed out permitted subclasses based on the above module requirements.
>> It returns all the classes listed in the PermittedSubclasses attribute that
>> it
On 1/12/2020 10:39 am, Mandy Chung wrote:
On Mon, 30 Nov 2020 20:57:32 GMT, Harold Seigel wrote:
src/java.base/share/classes/java/lang/Class.java line 4480:
4478: }
4479:
4480: private native Class[] getPermittedSubclasses0();
Does this JVM method return the permitted subclasses
On Mon, 30 Nov 2020 15:59:07 GMT, Jan Lahoda wrote:
>> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>>
>> From the original PR:
>>
>>> Please review the code for the second iteration of sealed classes. In this
>>> iteration we are:
>>>
>>> * Enhancing narrowing
On Mon, 30 Nov 2020 20:57:32 GMT, Harold Seigel wrote:
>> src/java.base/share/classes/java/lang/Class.java line 4480:
>>
>>> 4478: }
>>> 4479:
>>> 4480: private native Class[] getPermittedSubclasses0();
>>
>> Does this JVM method return the permitted subclasses or subinterfaces with
On Mon, 30 Nov 2020 19:44:52 GMT, Mandy Chung wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Improving getPermittedSubclasses javadoc.
>> - Merge branch 'master' into JDK-8246778
>> -
On Mon, 30 Nov 2020 15:59:07 GMT, Jan Lahoda wrote:
>> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>>
>> From the original PR:
>>
>>> Please review the code for the second iteration of sealed classes. In this
>>> iteration we are:
>>>
>>> * Enhancing narrowing
On Mon, 30 Nov 2020 15:59:07 GMT, Jan Lahoda wrote:
>> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>>
>> From the original PR:
>>
>>> Please review the code for the second iteration of sealed classes. In this
>>> iteration we are:
>>>
>>> * Enhancing narrowing
On Mon, 30 Nov 2020 15:59:07 GMT, Jan Lahoda wrote:
>> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>>
>> From the original PR:
>>
>>> Please review the code for the second iteration of sealed classes. In this
>>> iteration we are:
>>>
>>> * Enhancing narrowing
On Mon, 30 Nov 2020 15:59:07 GMT, Jan Lahoda wrote:
>> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>>
>> From the original PR:
>>
>>> Please review the code for the second iteration of sealed classes. In this
>>> iteration we are:
>>>
>>> * Enhancing narrowing
> This pull request replaces https://github.com/openjdk/jdk/pull/1227.
>
> From the original PR:
>
>> Please review the code for the second iteration of sealed classes. In this
>> iteration we are:
>>
>> * Enhancing narrowing reference conversion to allow for stricter
>> checking of cast
On Mon, 30 Nov 2020 09:55:56 GMT, Alan Bateman wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Improving getPermittedSubclasses javadoc.
>> - Merge branch 'master' into JDK-8246778
>> -
15 matches
Mail list logo
