On Fri, 25 Sep 2020 21:45:13 GMT, Ioi Lam wrote:
>> Yumin Qi has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8247536: Support for pre-generated java.lang.invoke classes in CDS static
>> archive
>
> test/hotspot/jtreg/runtime/cds/appcds/
> This patch is reorganized after 8252725, which is separated from this patch
> to refactor jlink glugin code. The previous
> webrev with hg can be found at:
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
> integrated, the
> regeneration of holder classes is simply to c
> This patch is reorganized after 8252725, which is separated from this patch
> to refactor jlink glugin code. The previous
> webrev with hg can be found at:
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
> integrated, the
> regeneration of holder classes is simply to c
On Fri, 25 Sep 2020 21:19:39 GMT, Yumin Qi wrote:
>> This patch is reorganized after 8252725, which is separated from this patch
>> to refactor jlink glugin code. The previous
>> webrev with hg can be found at:
>> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
>> integr
> This patch is reorganized after 8252725, which is separated from this patch
> to refactor jlink glugin code. The previous
> webrev with hg can be found at:
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
> integrated, the
> regeneration of holder classes is simply to c
> This patch is reorganized after 8252725, which is separated from this patch
> to refactor jlink glugin code. The previous
> webrev with hg can be found at:
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
> integrated, the
> regeneration of holder classes is simply to c
> This patch is reorganized after 8252725, which is separated from this patch
> to refactor jlink glugin code. The previous
> webrev with hg can be found at:
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
> integrated, the
> regeneration of holder classes is simply to c
On Wed, 16 Sep 2020 19:01:18 GMT, Ioi Lam wrote:
>> This patch is reorganized after 8252725, which is separated from this patch
>> to refactor jlink glugin code. The previous
>> webrev with hg can be found at:
>> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
>> integra
On Wed, 16 Sep 2020 19:05:56 GMT, Ioi Lam wrote:
>> This patch is reorganized after 8252725, which is separated from this patch
>> to refactor jlink glugin code. The previous
>> webrev with hg can be found at:
>> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
>> integra
On Tue, 15 Sep 2020 18:57:55 GMT, Yumin Qi wrote:
> This patch is reorganized after 8252725, which is separated from this patch
> to refactor jlink glugin code. The previous
> webrev with hg can be found at:
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
> integrated,
src/java.base/share/classes/java/lang/invoke/GenerateJLIClassesHelper.java
367 /** 368 * called from vm to generate MethodHandle holder classes 369
* @return @code { Object[] } if holder classes can be generated. 370 *
@param lines the output lines from @code { VM.cdsTraceResolve } 371 */
@code
HI, all
Please review changes for 8247536: Support for pre-generated
java.lang.invoke classes in CDS static archive.
What happened:
I pushed with commit comment:
8247536: Support for pre-generated java.lang.invoke classes in CDS static
archive
When created pullrequest, the tit
This patch is reorganized after 8252725, which is separated from this patch to
refactor jlink glugin code. The previous
webrev with hg can be found at:
http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725
integrated, the
regeneration of holder classes is simply to call the new
HI, Ioi
Thanks for the re-review, updated webrev:
http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-04/
Changed according to your suggestion, the only a little difference is move
traceResolve(String line) to InvokerBytecodeGenerator as a static package
public function so other package
On 8/24/20 3:53 PM, Ioi Lam wrote:
:
However, I suspect most people won't do this, because the benefit is
relatively small. Also, jlink doesn't support classpath apps, so you
would need to figure out what to use for "--add-modules". In the worst
case, the custom JDK would be over 100MB in
Hi Yumin,
This looks good overall. Here are my comments:
=
6065 size_t new_id = Atomic::add(&counter, (size_t)1);
6066 jio_snprintf(addr_buf, 20, INTPTR_FORMAT, new_id);
I think this should be SIZE_FORMAT
=
65 class KlassFactory : AllStatic {
On 8/20/20 5:10 PM, Mandy Chung wrote:
On 8/19/20 10:14 PM, Yumin Qi wrote:
HI, Mandy
Thanks for the review, I took one day off yesterday so just got a
detail look of your reply.
On 8/19/20 1:30 PM, Mandy Chung wrote:
On 8/17/20 12:37 PM, Yumin Qi wrote:
Hi, Ioi
Thanks for revie
Hi, Mandy, Ioi and Calvin
I have updated the new changed at:
http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-03/
In this version:
1) Added a new API to check if flag DumpLoadedClassList set and the file is
open. If true, call into vm to print out the trace line to the log file.
Hi, Mandy
On 8/20/20 5:10 PM, Mandy Chung wrote:
On 8/19/20 10:14 PM, Yumin Qi wrote:
HI, Mandy
Thanks for the review, I took one day off yesterday so just got a detail look
of your reply.
On 8/19/20 1:30 PM, Mandy Chung wrote:
On 8/17/20 12:37 PM, Yumin Qi wrote:
Hi, Ioi
Thanks f
On 8/19/20 10:14 PM, Yumin Qi wrote:
HI, Mandy
Thanks for the review, I took one day off yesterday so just got a
detail look of your reply.
On 8/19/20 1:30 PM, Mandy Chung wrote:
On 8/17/20 12:37 PM, Yumin Qi wrote:
Hi, Ioi
Thanks for review/suggestion. I have updated the webrev at
HI, Mandy
Thanks for the review, I took one day off yesterday so just got a detail look
of your reply.
On 8/19/20 1:30 PM, Mandy Chung wrote:
On 8/17/20 12:37 PM, Yumin Qi wrote:
Hi, Ioi
Thanks for review/suggestion. I have updated the webrev at the following link:
http://cr.openjdk.jav
On 8/17/20 12:37 PM, Yumin Qi wrote:
Hi, Ioi
Thanks for review/suggestion. I have updated the webrev at the
following link:
http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-02/
This patch leverages the TRACE_RESOLVE output and passes the trace
output to VM. VM then calls
Generate
HI, Sundar, David
Thanks.
I have update the webrev at the same link:
http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-02/ according Sundar's
suggestion.
Thanks.
Yumin
On 8/17/20 7:39 PM, sundararajan.athijegannat...@oracle.com wrote:
Hi David.
Thanks.
-Sundar
On 18/08/20
Hi David.
Thanks.
-Sundar
On 18/08/20 8:04 am, David Holmes wrote:
Hi Sundar,
On 18/08/2020 12:25 pm, sundararajan.athijegannat...@oracle.com wrote:
Not a full review of fresh changes. But couple of comments:
* src/hotspot/share/memory/lambdaFormInvokers.cpp and
src/hotspot/share/memory/la
Hi Sundar,
On 18/08/2020 12:25 pm, sundararajan.athijegannat...@oracle.com wrote:
Not a full review of fresh changes. But couple of comments:
* src/hotspot/share/memory/lambdaFormInvokers.cpp and
src/hotspot/share/memory/lambdaFormInvokers.hpp miss "Classpath
exception" clause in the copyrigh
Not a full review of fresh changes. But couple of comments:
* src/hotspot/share/memory/lambdaFormInvokers.cpp and
src/hotspot/share/memory/lambdaFormInvokers.hpp miss "Classpath
exception" clause in the copyright header
* I had suggested a change GenerateJLIClassesPlugin.java in last round
o
Hi, Ioi
Thanks for review/suggestion. I have updated the webrev at the following link:
http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-02/
Following changes done in this patch:
1) move regenerating holder classes into new added file:
lambdaFormInvokers.[ch]pp
"@lambda-form-invo
On 8/15/20 6:19 PM, Ioi Lam wrote:
To better capture what we're trying to do in this RFE, I've changed
the RFE title (and the subject of this email thread) to
https://bugs.openjdk.java.net/browse/JDK-8247536
Support for pre-generated java.lang.invoke classes in CDS static archive
I also update
To better capture what we're trying to do in this RFE, I've changed the
RFE title (and the subject of this email thread) to
https://bugs.openjdk.java.net/browse/JDK-8247536
Support for pre-generated java.lang.invoke classes in CDS static archive
I also update the RFE Description to give an over
29 matches
Mail list logo
