Re: RFR: 8248695: HostLocaleProviderAdapterImpl provides invalid date-only

2020-07-13 Thread Joe Wang
On 7/13/2020 9:04 PM, naoto.s...@oracle.com wrote: Hi Joe, On 7/13/20 7:28 PM, Joe Wang wrote: On 7/13/2020 7:01 PM, naoto.s...@oracle.com wrote: Hi Joe, Thank you for your review. On 7/13/20 3:55 PM, Joe Wang wrote: Hi Naoto, Would it make sense to provide an additional test using th

Re: RFR: 8248695: HostLocaleProviderAdapterImpl provides invalid date-only

2020-07-13 Thread naoto . sato
Hi Joe, On 7/13/20 7:28 PM, Joe Wang wrote: On 7/13/2020 7:01 PM, naoto.s...@oracle.com wrote: Hi Joe, Thank you for your review. On 7/13/20 3:55 PM, Joe Wang wrote: Hi Naoto, Would it make sense to provide an additional test using the public APIs similar to the one provided in the bug r

Re: RFR: 8248695: HostLocaleProviderAdapterImpl provides invalid date-only

2020-07-13 Thread Joe Wang
On 7/13/2020 7:01 PM, naoto.s...@oracle.com wrote: Hi Joe, Thank you for your review. On 7/13/20 3:55 PM, Joe Wang wrote: Hi Naoto, Would it make sense to provide an additional test using the public APIs similar to the one provided in the bug report? I'm sure yours is correct and covers

Re: RFR: 8248695: HostLocaleProviderAdapterImpl provides invalid date-only

2020-07-13 Thread naoto . sato
Hi Joe, Thank you for your review. On 7/13/20 3:55 PM, Joe Wang wrote: Hi Naoto, Would it make sense to provide an additional test using the public APIs similar to the one provided in the bug report? I'm sure yours is correct and covers more cases than the original, but it would be nice to h

Re: RFR: 8248695: HostLocaleProviderAdapterImpl provides invalid date-only

2020-07-13 Thread Joe Wang
Hi Naoto, Would it make sense to provide an additional test using the public APIs similar to the one provided in the bug report? I'm sure yours is correct and covers more cases than the original, but it would be nice to have an actual use case and use the public APIs. The report showed it was

Re: RFR: 8248695: HostLocaleProviderAdapterImpl provides invalid date-only

2020-07-13 Thread naoto . sato
Ping. On 7/7/20 3:55 PM, naoto.s...@oracle.com wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8248695 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8248695/webrev.00/ There were two causes that resulted in throw

RFR: 8248695: HostLocaleProviderAdapterImpl provides invalid date-only

2020-07-07 Thread naoto . sato
Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8248695 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8248695/webrev.00/ There were two causes that resulted in throwing exceptions. One was that the Host adapter for Windo