> Hi,
>
> As discussed in the
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html
> thread, this is the revised patch to address the use of '.' and '..' within
> Zip FS
>
> Zip FS needs to use "." and ".." as links to the current and parent
> directories and cannot
On Fri, 23 Jul 2021 10:36:51 GMT, Alan Bateman wrote:
> I wasn't suggesting there is a patch attached to that issue. Rather I was
> just pointing out that JDK-8251329 was being worked on already before this PR
> was created.
Ok, that makes sense. Thank you for the details.
-
PR:
On Fri, 23 Jul 2021 08:47:46 GMT, Jaikiran Pai wrote:
> This part I didn't understand. Did you mean to refer some other JBS issue?
> Because from what I see in https://bugs.openjdk.java.net/browse/JDK-8251329
> there's no patch attached to it (unless of course it's restricted to specific
>
On Fri, 2 Jul 2021 11:06:40 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8251329?
>>
>> As noted in that issue, if a zip filesystem created on top of a jar
>> containing a "./" entry is "walked" using the
On Fri, 2 Jul 2021 11:06:40 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8251329?
>>
>> As noted in that issue, if a zip filesystem created on top of a jar
>> containing a "./" entry is "walked" using the
On Fri, 2 Jul 2021 11:08:43 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
On 02/07/2021 18:16, Lance Andersen wrote:
:
That being said, if we want to follow Alan’s suggestion and throw an Exception,
I am OK with that as well.
Either way, we currently cannot access the file via Zip FS due to the call to
ZipPath::getResolvedPath() for all access and the path is only
On Jul 2, 2021, at 12:13 PM, Lance Andersen
mailto:lance.ander...@oracle.com>> wrote:
On Jul 2, 2021, at 8:08 AM, Jaikiran Pai
mailto:jai.forums2...@gmail.com>> wrote:
Hello Lance,
On 02/07/21 4:42 pm, Lance Andersen wrote:
Hi Jaikiran,
Consider:
try (var os =
On Jul 2, 2021, at 8:08 AM, Jaikiran Pai
mailto:jai.forums2...@gmail.com>> wrote:
Hello Lance,
On 02/07/21 4:42 pm, Lance Andersen wrote:
Hi Jaikiran,
Consider:
try (var os = Files.newOutputStream(ZIPFILE);
ZipOutputStream zos = new ZipOutputStream(os)) {
On 02/07/2021 13:08, Jaikiran Pai wrote:
Thank you for noticing this issue in my change and bringing this up. I
have a question around this use case. Please consider a small
variation to your example as below:
try (var os = Files.newOutputStream(ZIPFILE);
ZipOutputStream zos =
Hello Lance,
On 02/07/21 4:42 pm, Lance Andersen wrote:
Hi Jaikiran,
Consider:
try (var os = Files.newOutputStream(ZIPFILE);
ZipOutputStream zos = new ZipOutputStream(os)) {
zos.putNextEntry(new ZipEntry("../Hello.txt"));
zos.write("Hello
On Fri, 2 Jul 2021 11:06:40 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this proposed fix for
>> https://bugs.openjdk.java.net/browse/JDK-8251329?
>>
>> As noted in that issue, if a zip filesystem created on top of a jar
>> containing a "./" entry is "walked" using the
> Can I please get a review of this proposed fix for
> https://bugs.openjdk.java.net/browse/JDK-8251329?
>
> As noted in that issue, if a zip filesystem created on top of a jar
> containing a "./" entry is "walked" using the `Files.walkFileTree`, it leads
> to a infinite never ending iteration
13 matches
Mail list logo
