Re: RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources [v3]

2020-12-02 Thread Xue-Lei Andrew Fan
On Wed, 2 Dec 2020 18:42:36 GMT, Christoph Langer wrote: >> test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java line 37: >> >>> 35: * will not leave leaking socket file descriptors >>> 36: * @library /test/lib >>> 37: * @run main/othervm SSLSocketLeak >> >> See bellow

Re: RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources [v3]

2020-12-02 Thread Xue-Lei Andrew Fan
On Sun, 22 Nov 2020 18:27:56 GMT, Christoph Langer wrote: >> There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to >> leaking socket resources after JDK-8224829. >> >> The close method calls duplexCloseOutput() and duplexCloseInput(). In case >> of an exception in any of

Re: RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources [v3]

2020-12-02 Thread Christoph Langer
On Wed, 2 Dec 2020 18:01:04 GMT, Xue-Lei Andrew Fan wrote: >> Christoph Langer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Small test improvement > > test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java line 37: > >> 35: *

Re: RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources [v3]

2020-12-02 Thread Xue-Lei Andrew Fan
On Sun, 22 Nov 2020 18:27:56 GMT, Christoph Langer wrote: >> There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to >> leaking socket resources after JDK-8224829. >> >> The close method calls duplexCloseOutput() and duplexCloseInput(). In case >> of an exception in any of

Re: RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources

2020-11-27 Thread Xue-Lei Andrew Fan
On Fri, 27 Nov 2020 15:46:08 GMT, Christoph Langer wrote: >> I changed the check for when to do duplexClose to only do it when socket >> isConnected(). >> >> I also added a testcase which should work on all platforms. For windows I >> borrowed some functionality introduced lately with test

Re: RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources

2020-11-27 Thread Christoph Langer
On Sat, 21 Nov 2020 23:21:15 GMT, Christoph Langer wrote: >> There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to >> leaking socket resources after JDK-8224829. >> >> The close method calls duplexCloseOutput() and duplexCloseInput(). In case >> of an exception in any of

Re: RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources [v3]

2020-11-22 Thread Christoph Langer
> There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to > leaking socket resources after JDK-8224829. > > The close method calls duplexCloseOutput() and duplexCloseInput(). In case of > an exception in any of these methods, the call to closeSocket() is bypassed, > and the

Re: RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources [v2]

2020-11-22 Thread Christoph Langer
> There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to > leaking socket resources after JDK-8224829. > > The close method calls duplexCloseOutput() and duplexCloseInput(). In case of > an exception in any of these methods, the call to closeSocket() is bypassed, > and the

Re: RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources

2020-11-21 Thread Christoph Langer
On Sat, 21 Nov 2020 08:32:17 GMT, Christoph Langer wrote: > There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to > leaking socket resources after JDK-8224829. > > The close method calls duplexCloseOutput() and duplexCloseInput(). In case of > an exception in any of these

RFR: 8256818: SSLSocket that is never bound or connected leaks socket resources

2020-11-21 Thread Christoph Langer
There is a flaw in sun.security.ssl.SSLSocketImpl::close() which leads to leaking socket resources after JDK-8224829. The close method calls duplexCloseOutput() and duplexCloseInput(). In case of an exception in any of these methods, the call to closeSocket() is bypassed, and the underlying