On Tue, 1 Dec 2020 22:47:18 GMT, Ioi Lam wrote:
>> I can make a copy and put it under the
>> `open/test/hotspot/jtreg/runtime/cds/appcds/test-classes` dir. I'd still
>> need the `@compile` and would be something like `@compile
>> test-classes/LambdaEagerInitTest.java`.
>
> The `@compile` can
On Tue, 1 Dec 2020 22:19:55 GMT, Mandy Chung wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added a test
>
> test/hotspot/jtreg/runtime/cds/appcds/LambdaEagerInit.java line 77:
>
>> 75:
On Tue, 1 Dec 2020 22:34:58 GMT, Calvin Cheung wrote:
>> test/hotspot/jtreg/runtime/cds/appcds/LambdaEagerInit.java line 36:
>>
>>> 34: * @requires vm.cds
>>> 35: * @library /test/lib /test/hotspot/jtreg/runtime/cds/appcds
>>> 36: * @compile
>>>
On Tue, 1 Dec 2020 22:16:58 GMT, Mandy Chung wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added a test
>
> test/hotspot/jtreg/runtime/cds/appcds/LambdaEagerInit.java line 36:
>
>> 34: * @requires vm.cds
>>
On Tue, 1 Dec 2020 21:58:16 GMT, Calvin Cheung wrote:
>> Please review this change which includes:
>>
>> - If the `jdk.internal.lambda.disableEagerInitialization`property is
>> enabled, the `InnerClassLambdaMetafactory` will not involve CDS to archive
>> lambda proxy classes or to find them
On Tue, 1 Dec 2020 20:50:11 GMT, Claes Redestad wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added a test
>
> Looks good to me!
@mlchung, @iklam, @cl4es Thanks for the review.
I've added a test.
> Please review this change which includes:
>
> - If the `jdk.internal.lambda.disableEagerInitialization`property is enabled,
> the `InnerClassLambdaMetafactory` will not involve CDS to archive lambda
> proxy classes or to find them from an archive.
>
> - Not passing the `initialize` (same as
