On Wed, 27 Jan 2021 18:22:54 GMT, Jim Laskey wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyrights and rename containsLocation
>
> Nice clean up. LGTM
@JimLaskey @sundararajana - thanks for reviewing!
On Mon, 25 Jan 2021 16:09:01 GMT, Claes Redestad wrote:
>> This patch optimizes the code paths exercised by
>> `String.class.getResource("String.class")` by:
>>
>> - Adding an ASCII fast-path to methods verifying strings in the jimage,
>> which can then be done allocation-free
>> - Avoiding
On Sun, 31 Jan 2021 15:04:33 GMT, Alan Bateman wrote:
>> Nice clean up. LGTM
>
> @JimLaskey Do you have anything that documents the jimage format that could
> be checked into the repo to help with future changes in this change? Clearly
> any such document would need a warning in 96pt font that
Here is the original document (it's available in the jigsaw wiki)
How would you like it flushed out?
Cheers,
-- Jim
> On Jan 31, 2021, at 11:40 AM, Jim Laskey wrote:
>
> I’ve been handing out the original jimage docs on request. Surprisingly, it’s
> still accurate. Will dig up on Monday
I’ve been handing out the original jimage docs on request. Surprisingly, it’s
still accurate. Will dig up on Monday to post.
> On Jan 31, 2021, at 11:07 AM, Alan Bateman wrote:
>
> On Wed, 27 Jan 2021 18:22:54 GMT, Jim Laskey wrote:
>
>>> Claes Redestad has updated the pull request
On Wed, 27 Jan 2021 18:22:54 GMT, Jim Laskey wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyrights and rename containsLocation
>
> Nice clean up. LGTM
@JimLaskey Do you have anything that documents the
On Mon, 25 Jan 2021 16:09:01 GMT, Claes Redestad wrote:
>> This patch optimizes the code paths exercised by
>> `String.class.getResource("String.class")` by:
>>
>> - Adding an ASCII fast-path to methods verifying strings in the jimage,
>> which can then be done allocation-free
>> - Avoiding
On Mon, 25 Jan 2021 15:47:37 GMT, Alan Bateman wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Copyrights and rename containsLocation
>
> src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java
> This patch optimizes the code paths exercised by
> `String.class.getResource("String.class")` by:
>
> - Adding an ASCII fast-path to methods verifying strings in the jimage, which
> can then be done allocation-free
> - Avoiding the allocation of the `long[8]` attributes when verifying only
