Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton [v2]

2021-03-26 Thread Alexander Scherbatiy
On Wed, 24 Mar 2021 16:31:20 GMT, Claes Redestad wrote: >> Aleksei Voitylov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix style > > Looks good. The need to retain singleton/identity semantics of constants like > this when archivin

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton [v2]

2021-03-24 Thread Claes Redestad
On Tue, 23 Mar 2021 08:04:09 GMT, Aleksei Voitylov wrote: >> With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16. >> >> After JDK-8253081 with CDS enabled two instances of empty layer appear in >> the runtime. One comes from default initialization of >> java/lang/Module

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton [v2]

2021-03-24 Thread Aleksei Voitylov
On Tue, 23 Mar 2021 08:21:27 GMT, Alan Bateman wrote: >> Aleksei Voitylov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix style > > Marked as reviewed by alanb (Reviewer). Thanks Ioi, David and Alan for your reviews! -

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton [v2]

2021-03-23 Thread Alan Bateman
On Tue, 23 Mar 2021 08:04:09 GMT, Aleksei Voitylov wrote: >> With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16. >> >> After JDK-8253081 with CDS enabled two instances of empty layer appear in >> the runtime. One comes from default initialization of >> java/lang/Module

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton [v2]

2021-03-23 Thread Aleksei Voitylov
On Tue, 23 Mar 2021 06:47:50 GMT, Alan Bateman wrote: >> Aleksei Voitylov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix style > > src/java.base/share/classes/java/lang/ModuleLayer.java line 156: > >> 154: >> 155: static { >>

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton [v2]

2021-03-23 Thread Aleksei Voitylov
> With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16. > > After JDK-8253081 with CDS enabled two instances of empty layer appear in the > runtime. One comes from default initialization of > java/lang/ModuleLayer.EMPTY_LAYER, another one comes from CDS archive and is > re

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton

2021-03-22 Thread Alan Bateman
On Mon, 22 Mar 2021 19:40:19 GMT, Aleksei Voitylov wrote: > With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16. > > After JDK-8253081 with CDS enabled two instances of empty layer appear in the > runtime. One comes from default initialization of > java/lang/ModuleLayer

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton

2021-03-22 Thread David Holmes
On Mon, 22 Mar 2021 19:40:19 GMT, Aleksei Voitylov wrote: > With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16. > > After JDK-8253081 with CDS enabled two instances of empty layer appear in the > runtime. One comes from default initialization of > java/lang/ModuleLayer

Re: RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton

2021-03-22 Thread Ioi Lam
On Mon, 22 Mar 2021 19:40:19 GMT, Aleksei Voitylov wrote: > With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16. > > After JDK-8253081 with CDS enabled two instances of empty layer appear in the > runtime. One comes from default initialization of > java/lang/ModuleLayer

RFR: 8263968: CDS: java/lang/ModuleLayer.EMPTY_LAYER should be singleton

2021-03-22 Thread Aleksei Voitylov
With CDS and G1, test api/java_lang/ModuleLayer/Boot.html fails in JDK 16. After JDK-8253081 with CDS enabled two instances of empty layer appear in the runtime. One comes from default initialization of java/lang/ModuleLayer.EMPTY_LAYER, another one comes from CDS archive and is returned by Mo