On Tue, 24 Aug 2021 02:16:31 GMT, Mandy Chung wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @mlchung comments
>
> Thanks for creating a JBS issue. I'm okay to follow up the test improvement
> as a separate iss
On Fri, 20 Aug 2021 00:09:01 GMT, Calvin Cheung wrote:
>> Please review this change for adding a `jlink` command line option
>> `--generate-cds-archive` for generating CDS archives as a post processing
>> step during the creation of a custom JDK image.
>>
>> Details can be found in the corresp
On Fri, 20 Aug 2021 00:09:01 GMT, Calvin Cheung wrote:
>> Please review this change for adding a `jlink` command line option
>> `--generate-cds-archive` for generating CDS archives as a post processing
>> step during the creation of a custom JDK image.
>>
>> Details can be found in the corresp
On Fri, 20 Aug 2021 02:04:52 GMT, Mandy Chung wrote:
>> I'd prefer to leave it as is for now since it's in a test case and I don't
>> think the code is complex.
>
> This is fragile by setting `os.name`.
I've filed [JDK-8272868](https://bugs.openjdk.java.net/browse/JDK-8272868) to
follow-up the
On Thu, 19 Aug 2021 23:59:32 GMT, Calvin Cheung wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/CDSPlugin.java
>> line 121:
>>
>>> 119: @Override
>>> 120: public ResourcePool transform(ResourcePool in, ResourcePoolBuilder
>>> out) {
>>> 121: in.transformA
On Fri, 20 Aug 2021 00:09:01 GMT, Calvin Cheung wrote:
>> Please review this change for adding a `jlink` command line option
>> `--generate-cds-archive` for generating CDS archives as a post processing
>> step during the creation of a custom JDK image.
>>
>> Details can be found in the corresp
On Thu, 19 Aug 2021 23:56:00 GMT, Calvin Cheung wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/builder/DefaultImageBuilder.java
>> line 89:
>>
>>> 87: private final List args;
>>> 88: private final Set modules;
>>> 89: private Platform platform;
>>
>> Can `Defaul
> Please review this change for adding a `jlink` command line option
> `--generate-cds-archive` for generating CDS archives as a post processing
> step during the creation of a custom JDK image.
>
> Details can be found in the corresponding CSR
> [JDK-8269178](https://bugs.openjdk.java.net/brow
On Wed, 18 Aug 2021 23:55:25 GMT, Mandy Chung wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @mlchung comments
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/builder/DefaultImageBuilder.java
> line 89:
>
>> 87
On Wed, 18 Aug 2021 21:21:06 GMT, Calvin Cheung wrote:
> Please review this change for adding a `jlink` command line option
> `--generate-cds-archive` for generating CDS archives as a post processing
> step during the creation of a custom JDK image.
>
> Details can be found in the correspondin
Please review this change for adding a `jlink` command line option
`--generate-cds-archive` for generating CDS archives as a post processing step
during the creation of a custom JDK image.
Details can be found in the corresponding CSR
[JDK-8269178](https://bugs.openjdk.java.net/browse/JDK-82691
11 matches
Mail list logo
