> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Wed, 28 Apr 2021 08:20:05 GMT, Chris Hegarty wrote:
>> src/java.base/share/classes/sun/nio/ch/IOUtil.java line 466:
>>
>>> 464: }
>>> 465:
>>> 466: private static final JavaNioAccess NIO_ACCESS =
>>> SharedSecrets.getJavaNioAccess();
>>
>> It might be cleaner to move to acquire/rel
On Thu, 20 May 2021 13:00:14 GMT, Maurizio Cimadamore
wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains 35
>> addit
On Thu, 20 May 2021 13:05:22 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Thu, 20 May 2021 13:00:15 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Thu, 13 May 2021 10:52:35 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Wed, 12 May 2021 15:07:37 GMT, Maurizio Cimadamore
wrote:
>> src/hotspot/share/runtime/sharedRuntime.hpp line 465:
>>
>>> 463: static void restore_native_result(MacroAssembler *_masm, BasicType
>>> ret_type, int frame_slots);
>>> 464:
>>> 465: static void move32_64(MacroAssembler* ma
On Wed, 12 May 2021 14:53:39 GMT, Jorn Vernee wrote:
>> src/hotspot/cpu/x86/universalUpcallHandler_x86_64.cpp line 472:
>>
>>> 470: __ block_comment("} preserve_callee_saved_regs ");
>>> 471:
>>> 472: // TODO mxcsr
>>
>> Anything left to do with mxcsr?
>
> I guess this slipped through with
On Wed, 12 May 2021 13:57:21 GMT, Vladimir Ivanov wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * Remove unused imports
>> * Fix broken javadoc after removal of @throws clauses
>> * Remove other `@Call
On Wed, 12 May 2021 14:06:46 GMT, Vladimir Ivanov wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * Remove unused imports
>> * Fix broken javadoc after removal of @throws clauses
>> * Remove other `@Call
On Mon, 10 May 2021 20:43:20 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Mon, 10 May 2021 20:43:20 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Fri, 30 Apr 2021 17:20:21 GMT, Mandy Chung wrote:
>>> I think the implementation does not support that. I will also need to look
>>> into how this impacts JDK-8266010. As I suggest earlier, I'm fine to do
>>> this as a follow up after integration.
>>
>> I've added `@CS` in the interface met
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Mon, 10 May 2021 18:15:01 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Thu, 6 May 2021 14:23:27 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Tue, 4 May 2021 12:01:44 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/module/IllegalNativeAccessChecker.java
>> line 34:
>>
>>> 32: import java.util.Set;
>>> 33:
>>> 34: public final class IllegalNativeAccessChecker {
>>
>> Are you sure about the name of the
On Tue, 4 May 2021 12:05:15 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
On Tue, 4 May 2021 08:12:23 GMT, Alan Bateman wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert bad change in benchmark copyright
>> - Do not apply optimized bound check if accessed offset/length do
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Tue, 4 May 2021 08:20:43 GMT, Alan Bateman wrote:
> Just to double, there is no way to enable native access for modules in module
> layers (other than the boot layer), right?
No, at the moment it is not possible to enable native access programmatically.
We will explore something along those
On Fri, 30 Apr 2021 15:20:42 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Fri, 30 Apr 2021 12:24:38 GMT, Maurizio Cimadamore
wrote:
> I've added `@CS` in the interface methods too. I've also added a stronger
> test which creates method handles in one module (which doesn't have native
> access) and then calls them from another module (which does NOT have native
>
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Thu, 29 Apr 2021 18:18:00 GMT, Mandy Chung wrote:
> I think the implementation does not support that. I will also need to look
> into how this impacts JDK-8266010. As I suggest earlier, I'm fine to do this
> as a follow up after integration.
I've added `@CS` in the interface methods too. I'
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Thu, 29 Apr 2021 10:31:29 GMT, Maurizio Cimadamore
wrote:
> I think I expect that, with caller sensitive, it is possible from a client in
> an "enabled" module to obtain a MethodHandle, and then pass it to an
> unprivileged module, which then calls it, and works ok. This matches my
> expec
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Wed, 28 Apr 2021 18:33:36 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Wed, 28 Apr 2021 23:22:38 GMT, Mandy Chung wrote:
> My statement was overly simplified, sorry. If `handle` is invoked in another
> module B and invoked by a class in module B, which module (the `lookup`'s
> module or ) do you expect be the caller to check against for native access
> check?
On Wed, 28 Apr 2021 21:10:33 GMT, Maurizio Cimadamore
wrote:
> I just did a test:
>
> ```
> public class TestLookup {
> public static void main(String[] args) throws Throwable {
> MethodHandle handle =
> MethodHandles.lookup().findVirtual(CLinker.class, "downcallHandle",
> MethodT
On Wed, 28 Apr 2021 18:44:18 GMT, Daniel Fuchs wrote:
>> I think the method is called during module bootstrap - I don't think there
>> is a race in practice. This method is also called in other parts of
>> ModuleBootstrap. The code you allude to is called during initialization of
>> the Illega
On Wed, 28 Apr 2021 20:40:49 GMT, Mandy Chung wrote:
> > To be clear - by aliasing you mean when the @CallerSensitive implementation
> > is called with invokeinterface - so, e.g. doing
> > `MethodHandles.lookup().findVirtual(CLinker.class, ...)` right?
>
> Yes. The caller would be java.base if
On Wed, 28 Apr 2021 20:38:47 GMT, Maurizio Cimadamore
wrote:
> To be clear - by aliasing you mean when the @CallerSensitive implementation
> is called with invokeinterface - so, e.g. doing
> `MethodHandles.lookup().findVirtual(CLinker.class, ...)` right?
Yes. The caller would be java.base i
On Wed, 28 Apr 2021 18:33:36 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 19:02:57 GMT, Daniel Fuchs wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryA
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 18:19:14 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/module/IllegalNativeAccessChecker.java
>> line 78:
>>
>>> 76: int index = 0;
>>> 77: // the system property is removed after decoding
>>> 78: String value = getAndRe
On Wed, 28 Apr 2021 18:26:30 GMT, Maurizio Cimadamore
wrote:
> test/jdk/jdk/internal/reflect/CallerSensitive/CheckCSMs.java
Yes that's the test. That test misses to catch your case where aliasing may be
possible.
-
PR: https://git.openjdk.java.net/jdk/pull/3699
On Wed, 28 Apr 2021 17:53:44 GMT, Daniel Fuchs wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/java.base/share/classes/jdk/internal/module/IllegalNativeAccessCh
On Wed, 28 Apr 2021 18:23:41 GMT, Mandy Chung wrote:
> > I believe that we had to move @CallerSensitive out of interfaces because
> > there was a test that was checking that @cs was not put on "virtual"
> > methods.
>
> Good if we do have such test. We need to re-examine this with the security
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Wed, 28 Apr 2021 18:07:32 GMT, Daniel Fuchs wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/java.base/share/classes/jdk/internal/module/IllegalNativeAccessCh
On Wed, 28 Apr 2021 18:02:03 GMT, Mandy Chung wrote:
> I reviewed the `--enable-native-access` related change that looks fine.
>
> > Access to restricted methods from any other module not in the list is
> > disallowed and will result in an IllegalAccessException.
>
> I think you meant to say `
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 13:47:43 GMT, Maurizio Cimadamore
wrote:
>> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java
>> line 270:
>>
>>> 268:
>>> 269: /**
>>> 270: * Converts a Java string into a null-terminated C string, using
>>> the platform's default charse
On Wed, 28 Apr 2021 12:47:36 GMT, Chris Hegarty wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinke
On Wed, 28 Apr 2021 13:08:26 GMT, Chris Hegarty wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/Memory
On Wed, 28 Apr 2021 10:42:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 28 Apr 2021 09:10:37 GMT, Chris Hegarty wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/Resour
On Wed, 28 Apr 2021 09:06:29 GMT, Chris Hegarty wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address first batch of review comments
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/Resour
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Wed, 28 Apr 2021 09:06:29 GMT, Chris Hegarty wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk.java.
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.jav
On Tue, 27 Apr 2021 18:40:24 GMT, Alan Bateman wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk.java.n
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.jav
On Tue, 27 Apr 2021 18:46:02 GMT, Alan Bateman wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk.java.n
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.jav
On Mon, 26 Apr 2021 17:10:13 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.jav
This PR contains the API and implementation changes for JEP-412 [1]. A more
detailed description of such changes, to avoid repetitions during the review
process, is included as a separate comment.
[1] - https://openjdk.java.net/jeps/412
-
Commit messages:
- Add linker test exclude
81 matches
Mail list logo
