Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-13 Thread Vladimir Ivanov
On Wed, 12 May 2021 15:07:37 GMT, Maurizio Cimadamore wrote: >> src/hotspot/share/runtime/sharedRuntime.hpp line 465: >> >>> 463: static void restore_native_result(MacroAssembler *_masm, BasicType >>> ret_type, int frame_slots); >>> 464: >>> 465: static void move32_64(MacroAssembler*

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-12 Thread Vladimir Ivanov
On Wed, 12 May 2021 14:53:39 GMT, Jorn Vernee wrote: >> src/hotspot/cpu/x86/universalUpcallHandler_x86_64.cpp line 472: >> >>> 470: __ block_comment("} preserve_callee_saved_regs "); >>> 471: >>> 472: // TODO mxcsr >> >> Anything left to do with mxcsr? > > I guess this slipped through

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-12 Thread Maurizio Cimadamore
On Wed, 12 May 2021 13:57:21 GMT, Vladimir Ivanov wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> * Remove unused imports >> * Fix broken javadoc after removal of @throws clauses >> * Remove other

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-12 Thread Jorn Vernee
On Wed, 12 May 2021 14:06:46 GMT, Vladimir Ivanov wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> * Remove unused imports >> * Fix broken javadoc after removal of @throws clauses >> * Remove other

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-12 Thread Vladimir Ivanov
On Mon, 10 May 2021 20:43:20 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-412 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] -

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-12 Thread Vladimir Ivanov
On Mon, 10 May 2021 20:43:20 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-412 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] -

Re: RFR: 8264774: Implementation of Foreign Function and Memory API (Incubator) [v16]

2021-05-10 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-412 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/412 Maurizio Cimadamore has updated the pull