On Tue, 27 Apr 2021 19:07:45 GMT, Igor Ignatyev wrote:
> > I guess this should really be named `isJVMCICompilerEnabled` now and the
> > `vm.graal.enabled` predicate renamed to `vm.jvmcicompiler.enabled` but
> > maybe that's too big a change (or can be done later).
>
> @dougxc, I don't think
On Tue, 13 Apr 2021 09:30:23 GMT, Doug Simon wrote:
> I guess this should really be named `isJVMCICompilerEnabled` now and the
> `vm.graal.enabled` predicate renamed to `vm.jvmcicompiler.enabled` but maybe
> that's too big a change (or can be done later).
@dougxc, I don't think that we should
On Tue, 13 Apr 2021 09:30:23 GMT, Doug Simon wrote:
>> We would definitely like to be able to continue testing of GraalVM with the
>> JDK set of jtreg tests. So keeping `Compiler::isGraalEnabled()` working like
>> it does today is important.
>
>> @dougxc I restored Compiler::isGraalEnabled().
On Sun, 11 Apr 2021 10:25:47 GMT, Doug Simon wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Sun, 11 Apr 2021 10:25:47 GMT, Doug Simon wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Mon, 12 Apr 2021 17:18:36 GMT, Vladimir Kozlov wrote:
>> make/common/Modules.gmk line 68:
>>
>>> 66:
>>> 67: # Filter out Graal specific modules
>>> 68: MODULES_FILTER += jdk.internal.vm.compiler
>>
>> If we are unconditionally filtering out these modules, then why leave the
>>
On Fri, 9 Apr 2021 22:26:40 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Java-based JIT compiler (Graal) from JDK:
>>
>> - `jdk.internal.vm.compiler` — the Graal compiler
>> - `jdk.internal.vm.compiler.management` — Graal's
On Mon, 12 Apr 2021 16:18:32 GMT, Erik Joelsson wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Fri, 9 Apr 2021 22:26:40 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Java-based JIT compiler (Graal) from JDK:
>>
>> - `jdk.internal.vm.compiler` — the Graal compiler
>> - `jdk.internal.vm.compiler.management` — Graal's
On Sat, 10 Apr 2021 17:41:05 GMT, Vladimir Kozlov wrote:
>> Marked as reviewed by iignatyev (Reviewer).
>
> Thank you, Igor. I filed https://bugs.openjdk.java.net/browse/JDK-8265032
We would definitely like to be able to continue testing of GraalVM with the JDK
set of jtreg tests. So keeping
On Sat, 10 Apr 2021 16:47:45 GMT, Igor Ignatyev wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Sat, 10 Apr 2021 16:36:54 GMT, Vladimir Kozlov wrote:
>> should we remove `sun.hotspot.code.Compiler::isGraalEnabled` method and
>> update a few of its users accordingly?
>> what about `vm.graal.enabled` `@requires` property?
>
> @iignatev If you think that I should clean tests anyway I
On Fri, 9 Apr 2021 22:26:40 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Java-based JIT compiler (Graal) from JDK:
>>
>> - `jdk.internal.vm.compiler` — the Graal compiler
>> - `jdk.internal.vm.compiler.management` — Graal's
On Sat, 10 Apr 2021 15:38:11 GMT, Igor Ignatyev wrote:
>> Vladimir Kozlov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Sat, 10 Apr 2021 15:38:11 GMT, Igor Ignatyev wrote:
> should we remove `sun.hotspot.code.Compiler::isGraalEnabled` method and
> update a few of its users accordingly?
> what about `vm.graal.enabled` `@requires` property?
Thank you, @iignatev for looking on changes.
I forgot to mention that
On Fri, 9 Apr 2021 22:26:40 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Java-based JIT compiler (Graal) from JDK:
>>
>> - `jdk.internal.vm.compiler` — the Graal compiler
>> - `jdk.internal.vm.compiler.management` — Graal's
> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to
> Java-based JIT compiler (Graal) from JDK:
>
> - `jdk.internal.vm.compiler` — the Graal compiler
> - `jdk.internal.vm.compiler.management` — Graal's `MBean`
> - `test/hotspot/jtreg/compiler/graalunit` — Graal's
17 matches
Mail list logo
