Re: RFR: 8266310: deadlock while loading the JNI code [v8]

2021-06-17 Thread Mandy Chung
On Thu, 17 Jun 2021 18:15:52 GMT, Aleksei Voitylov wrote: > Thanks Mandy for the thorough review, I'll definitely do that. Shall we wait > for Alan opinion as well? I think you can proceed posting a PR for jdk17 as the new version has addressed Alan's concern of using ThreadLocal. Alan can

Re: RFR: 8266310: deadlock while loading the JNI code [v8]

2021-06-17 Thread Mandy Chung
On Wed, 16 Jun 2021 07:51:32 GMT, Aleksei Voitylov wrote: >> Please review this PR which fixes the deadlock in ClassLoader between the >> two lock objects - a lock object associated with the class being loaded, and >> the ClassLoader.loadedLibraryNames hash map, locked during the native >>

Re: RFR: 8266310: deadlock while loading the JNI code [v8]

2021-06-17 Thread Mandy Chung
On Thu, 17 Jun 2021 18:12:19 GMT, Aleksei Voitylov wrote: >> test/jdk/java/lang/ClassLoader/loadLibraryDeadlock/TestLoadLibraryDeadlock.java >> line 95: >> >>> 93: Collections.addAll(args, "cvf", Paths.get(testClassPath, >>> outputJar).toString()); >>> 94: for (String c :

Re: RFR: 8266310: deadlock while loading the JNI code [v8]

2021-06-17 Thread Aleksei Voitylov
On Wed, 16 Jun 2021 07:51:32 GMT, Aleksei Voitylov wrote: >> Please review this PR which fixes the deadlock in ClassLoader between the >> two lock objects - a lock object associated with the class being loaded, and >> the ClassLoader.loadedLibraryNames hash map, locked during the native >>

Re: RFR: 8266310: deadlock while loading the JNI code [v8]

2021-06-17 Thread Aleksei Voitylov
On Wed, 16 Jun 2021 15:59:44 GMT, Mandy Chung wrote: >> Aleksei Voitylov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address review comments > > test/jdk/java/lang/ClassLoader/loadLibraryDeadlock/TestLoadLibraryDeadlock.java > line

Re: RFR: 8266310: deadlock while loading the JNI code [v8]

2021-06-16 Thread Mandy Chung
On Wed, 16 Jun 2021 07:51:32 GMT, Aleksei Voitylov wrote: >> Please review this PR which fixes the deadlock in ClassLoader between the >> two lock objects - a lock object associated with the class being loaded, and >> the ClassLoader.loadedLibraryNames hash map, locked during the native >>

Re: RFR: 8266310: deadlock while loading the JNI code [v8]

2021-06-16 Thread Mandy Chung
On Wed, 16 Jun 2021 07:51:32 GMT, Aleksei Voitylov wrote: >> Please review this PR which fixes the deadlock in ClassLoader between the >> two lock objects - a lock object associated with the class being loaded, and >> the ClassLoader.loadedLibraryNames hash map, locked during the native >>

Re: RFR: 8266310: deadlock while loading the JNI code [v8]

2021-06-16 Thread Aleksei Voitylov
> Please review this PR which fixes the deadlock in ClassLoader between the two > lock objects - a lock object associated with the class being loaded, and the > ClassLoader.loadedLibraryNames hash map, locked during the native library > load operation. > > Problem being fixed: > > The initial