Re: RFR: 8266460: java.io tests fail on null stream with upgraded jtreg/TestNG

2021-05-04 Thread Brian Burkhalter
On Tue, 4 May 2021 20:45:43 GMT, Lance Andersen wrote: > Hi all, > > This fix addresses a change in TestNG behavior for the Before/AfterGroups > annotations that was introduced via > https://github.com/cbeust/testng/pull/2167. The tests have been verified > against the latest TestNG

Re: RFR: 8266460: java.io tests fail on null stream with upgraded jtreg/TestNG

2021-05-04 Thread Brian Burkhalter
On Tue, 4 May 2021 22:49:22 GMT, Lance Andersen wrote: >> Ah. I was just thinking of consistency with other tests. Up to you. > > I think your milage will vary depending on the author and the IDE being used. > My primary concern was to address the issue for the failing test and > Intellij

Re: RFR: 8266460: java.io tests fail on null stream with upgraded jtreg/TestNG

2021-05-04 Thread Lance Andersen
On Tue, 4 May 2021 22:44:18 GMT, Brian Burkhalter wrote: >> That's IntelliJ magic. I can update if you prefer and can let IntelliJ >> optimize all of the imports > > Ah. I was just thinking of consistency with other tests. Up to you. I think your milage will vary depending on the author and

Re: RFR: 8266460: java.io tests fail on null stream with upgraded jtreg/TestNG

2021-05-04 Thread Brian Burkhalter
On Tue, 4 May 2021 22:42:57 GMT, Lance Andersen wrote: >> test/jdk/java/io/InputStream/NullInputStream.java line 33: >> >>> 31: import java.io.InputStream; >>> 32: >>> 33: import static org.testng.Assert.*; >> >> Would it not be more standard to put the new imports just after this import? >>

Re: RFR: 8266460: java.io tests fail on null stream with upgraded jtreg/TestNG

2021-05-04 Thread Lance Andersen
On Tue, 4 May 2021 22:36:29 GMT, Brian Burkhalter wrote: >> Hi all, >> >> This fix addresses a change in TestNG behavior for the Before/AfterGroups >> annotations that was introduced via >> https://github.com/cbeust/testng/pull/2167. The tests have been verified >> against the latest

Re: RFR: 8266460: java.io tests fail on null stream with upgraded jtreg/TestNG

2021-05-04 Thread Brian Burkhalter
On Tue, 4 May 2021 20:45:43 GMT, Lance Andersen wrote: > Hi all, > > This fix addresses a change in TestNG behavior for the Before/AfterGroups > annotations that was introduced via > https://github.com/cbeust/testng/pull/2167. The tests have been verified > against the latest TestNG

RFR: 8266460: java.io tests fail on null stream with upgraded jtreg/TestNG

2021-05-04 Thread Lance Andersen
Hi all, This fix addresses a change in TestNG behavior for the Before/AfterGroups annotations that was introduced via https://github.com/cbeust/testng/pull/2167. The tests have been verified against the latest TestNG release and continue to run with the current TestNG release used by