Re: RFR: 8266461: tools/jmod/hashes/HashesTest.java fails: static @Test methods [v4]

2021-05-14 Thread Lance Andersen
On Fri, 14 May 2021 08:02:29 GMT, Alan Bateman wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adjust imports and spacing > > test/jdk/tools/jmod/hashes/HashesTest.java line 389: > >> 387:

Re: RFR: 8266461: tools/jmod/hashes/HashesTest.java fails: static @Test methods [v4]

2021-05-14 Thread Alan Bateman
On Thu, 13 May 2021 20:38:20 GMT, Lance Andersen wrote: >> HI all, >> >> Please review the fix to HashesTest.java to support running on TestNG 7.4. >> >> The fix adds a no-arg constructor which TestNG requires. >> >> The change allows the test to run with the current jtreg as well as the

Re: RFR: 8266461: tools/jmod/hashes/HashesTest.java fails: static @Test methods [v4]

2021-05-13 Thread Mandy Chung
On Thu, 13 May 2021 20:38:20 GMT, Lance Andersen wrote: >> HI all, >> >> Please review the fix to HashesTest.java to support running on TestNG 7.4. >> >> The fix adds a no-arg constructor which TestNG requires. >> >> The change allows the test to run with the current jtreg as well as the

Re: RFR: 8266461: tools/jmod/hashes/HashesTest.java fails: static @Test methods [v4]

2021-05-13 Thread Lance Andersen
> HI all, > > Please review the fix to HashesTest.java to support running on TestNG 7.4. > > The fix adds a no-arg constructor which TestNG requires. > > The change allows the test to run with the current jtreg as well as the > upcoming jtreg > > > Best > Lance Lance Andersen has updated