On Thu, 9 Sep 2021 16:36:44 GMT, Andy Herrick wrote:
> This is a backport from JDK-18
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/305
This is a backport from JDK-18
-
Commit messages:
- JDK-8271868: Warn user when using mac-sign option with unsigned
app-image.
Changes: https://git.openjdk.java.net/jdk17/pull/305/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=305&range=00
Issue: https://bugs.
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8271868: Warn user when using mac-sign optio
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8271868: Warn user when using mac-sign optio
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8271868: Warn user when using mac-sign optio
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8271868: Warn user when using mac-sign optio
On Thu, 5 Aug 2021 17:07:13 GMT, Andy Herrick wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> Andy Herrick has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8271868: Warn user when using mac-sign optio
> 8271868: Warn user when using mac-sign option with unsigned app-image.
Andy Herrick has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8271868: Warn user when using mac-sign option with unsigned app-image.
-
Changes:
- all: http
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
My understanding of this enhancement is to warn user when app image created
without --mac-sign is used in building a signed package. I.e. to warn user they
misused --ma
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
First of all why we only want to cover case when app-image was produced without
--mac-sign? If we want to cover such case only, then we need to use approach
suggested b
On Wed, 4 Aug 2021 20:56:46 GMT, Alexander Matveev wrote:
>> 8271868: Warn user when using mac-sign option with unsigned app-image.
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java
> line 142:
>
>> 140: // is not allready signed.
>> 141:
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
The purpose of this change is to catch the case (and emit a warning) when user
creates an app-image w/o using --mac-sign, and then uses that app image to
build a pkg or
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
What options exist for building a package from app image with invalid signature?
-
PR: https://git.openjdk.java.net/jdk/pull/5004
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
I think it will not work. User might modify app image after it was created and
it will invalidate signature.
-
PR: https://git.openjdk.java.net/jdk/pull/50
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
What if we save "signed/not signed" flag in ".jpackage.xml" when building app
image and read its value instead of guessing if they signed app image or not
using `codesi
On Wed, 4 Aug 2021 20:00:37 GMT, Andy Herrick wrote:
> 8271868: Warn user when using mac-sign option with unsigned app-image.
Changes requested by almatvee (Reviewer).
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java
line 877:
> 875: try {
> 876:
8271868: Warn user when using mac-sign option with unsigned app-image.
-
Commit messages:
- JDK-8271868: Warn user when using mac-sign option with unsigned app-image.
- JDK-8271868: Warn user when using mac-sign option with unsigned app-image.
- JDK-8271868: Warn user when using ma
17 matches
Mail list logo
