Re: RFR: 8272137: Make Iterable classes streamable

2021-08-14 Thread Brian Goetz
On Mon, 9 Aug 2021 12:28:23 GMT, CC007 wrote: > create Streamable and ParallelStreamable interface and use them in Collection > and Optional I object to this change. These issues were explored in the JSR 335 EG and it was agreed that this abstraction did not carry its weight. In any case, i

Re: RFR: 8272137: Make Iterable classes streamable

2021-08-14 Thread Brian Goetz
Starting with a PR is not the way to add significant API surface to the JDK. You have to first build consensus on the mailing list for the design concept before we start talking about code. FTR, Interfaces like these were already discussed and rejected in the JSR 335 design discussions.

Re: RFR: 8272137: Make Iterable classes streamable

2021-08-14 Thread CC007
On Sat, 14 Aug 2021 00:53:06 GMT, liach wrote: > Aren't all iterable implementations effectively streamable if they properly > implement `spliterator`? And the spliterator implementation can always be > sequential or parallel, dependent on how you feed it into `StreamSupport`. Yes indeed, but

Re: RFR: 8272137: Make Iterable classes streamable

2021-08-14 Thread CC007
On Mon, 9 Aug 2021 12:28:23 GMT, CC007 wrote: > create Streamable and ParallelStreamable interface and use them in Collection > and Optional The name of this pull request is a bit wrong, but it had to be the same as the JBS name. The interfaces don't make the Iterable have stream and parall

Re: RFR: 8272137: Make Iterable classes streamable

2021-08-14 Thread Rémi Forax
On Mon, 9 Aug 2021 12:28:23 GMT, CC007 wrote: > create Streamable and ParallelStreamable interface and use them in Collection > and Optional Hi Rick, I do not think that such interfaces are a good addition to the JDK, we do not want to promote the fact that you can create a Stream from an Ite

Re: RFR: 8272137: Make Iterable classes streamable

2021-08-13 Thread liach
On Mon, 9 Aug 2021 12:28:23 GMT, CC007 wrote: > create Streamable and ParallelStreamable interface and use them in Collection > and Optional Aren't all iterable implementations effectively streamable if they properly implement `spliterator`? And the spliterator implementation can always be s

Re: RFR: 8272137: Make Iterable classes streamable

2021-08-13 Thread CC007
On Mon, 9 Aug 2021 12:28:23 GMT, CC007 wrote: > create Streamable and ParallelStreamable interface and use them in Collection > and Optional I couldn't think of any, but if there are more places where these interfaces could be used, please tell me, so I can add them. - PR: https

Re: RFR: 8272137: Make Iterable classes streamable

2021-08-13 Thread CC007
On Mon, 9 Aug 2021 12:28:23 GMT, CC007 wrote: > create Streamable and ParallelStreamable interface and use them in Collection > and Optional Something seemed to have gone wrong with the jcheck - PR: https://git.openjdk.java.net/jdk/pull/5050

RFR: 8272137: Make Iterable classes streamable

2021-08-13 Thread CC007
create Streamable and ParallelStreamable interface and use them in Collection and Optional - Commit messages: - 8272137: no CR - 8272137: create Streamable and ParallelStreamable interface and use in Collection and Optional Changes: https://git.openjdk.java.net/jdk/pull/5050/file