Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-11-03 Thread Stuart Marks
On Fri, 29 Oct 2021 15:35:50 GMT, Roger Riggs wrote: >> The ObjectInputStream.GetField method `get(String name, Object val)` should >> have been throwing >> a ClassNotFoundException if the class was not found. Instead the >> implementation was returning null. >> A design error does not allow t

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-11-03 Thread Daniel Fuchs
On Fri, 29 Oct 2021 15:35:50 GMT, Roger Riggs wrote: >> The ObjectInputStream.GetField method `get(String name, Object val)` should >> have been throwing >> a ClassNotFoundException if the class was not found. Instead the >> implementation was returning null. >> A design error does not allow t

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-10-29 Thread Roger Riggs
On Fri, 29 Oct 2021 16:14:57 GMT, Michael McMahon wrote: > How likely is it that existing code is using ObjectInputStream::getFields and > is already handling class not found by checking for null return from the > returned GetField? Very unlikely, a field value may be null for because it reall

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-10-29 Thread Naoto Sato
On Fri, 29 Oct 2021 15:35:50 GMT, Roger Riggs wrote: >> The ObjectInputStream.GetField method `get(String name, Object val)` should >> have been throwing >> a ClassNotFoundException if the class was not found. Instead the >> implementation was returning null. >> A design error does not allow t

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-10-29 Thread Michael McMahon
On Fri, 29 Oct 2021 15:35:50 GMT, Roger Riggs wrote: >> The ObjectInputStream.GetField method `get(String name, Object val)` should >> have been throwing >> a ClassNotFoundException if the class was not found. Instead the >> implementation was returning null. >> A design error does not allow t

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-10-29 Thread Joe Darcy
On Fri, 29 Oct 2021 15:35:50 GMT, Roger Riggs wrote: >> The ObjectInputStream.GetField method `get(String name, Object val)` should >> have been throwing >> a ClassNotFoundException if the class was not found. Instead the >> implementation was returning null. >> A design error does not allow t

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-10-29 Thread Roger Riggs
On Fri, 29 Oct 2021 15:06:12 GMT, Daniel Fuchs wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct comment on the handling of ClassNotFoundException > > src/java.base/share/classes/java/io/ObjectInputStream.java

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException [v2]

2021-10-29 Thread Roger Riggs
> The ObjectInputStream.GetField method `get(String name, Object val)` should > have been throwing > a ClassNotFoundException if the class was not found. Instead the > implementation was returning null. > A design error does not allow the `get(String name, Object val)` method to > throw CNFE a

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException

2021-10-29 Thread Daniel Fuchs
On Wed, 20 Oct 2021 21:57:29 GMT, Roger Riggs wrote: > The ObjectInputStream.GetField method `get(String name, Object val)` should > have been throwing > a ClassNotFoundException if the class was not found. Instead the > implementation was returning null. > A design error does not allow the `g

Re: RFR: 8273660: De-Serialization Stack is suppressing ClassNotFoundException

2021-10-29 Thread Julia Boes
On Wed, 20 Oct 2021 21:57:29 GMT, Roger Riggs wrote: > The ObjectInputStream.GetField method `get(String name, Object val)` should > have been throwing > a ClassNotFoundException if the class was not found. Instead the > implementation was returning null. > A design error does not allow the `g