On Sun, 26 Sep 2021 13:58:35 GMT, Andrey Turbanov
wrote:
> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
> method.
> It's makes code a bit easier to read.
> Noticing negation before long chain of method calls is hard.
LGTM
-
Marked as reviewed by mchu
On Sun, 26 Sep 2021 13:58:35 GMT, Andrey Turbanov
wrote:
> I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
> method.
> It's makes code a bit easier to read.
> Noticing negation before long chain of method calls is hard.
Looks okay, this code pre-dates the isEmpty met
I propose to replace usages of !Optional.isPresent() with Optional.isEmpty
method.
It's makes code a bit easier to read.
Noticing negation before long chain of method calls is hard.
-
Commit messages:
- [PATCH] Use Optional.isEmpty instead of !Optional.isPresent in jdk.jlink
Change
