Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v5]

2021-11-14 Thread Alan Bateman
On Sun, 14 Nov 2021 14:41:21 GMT, Naoto Sato wrote: > Initially, I thought that was the case, but I mistook your suggestion as > setting only `notSupportedJnuEncoding` in initPhase1. Reverted the fallback > location into `initPhase1()`. np, it's always tricky to touch code that executes early

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v5]

2021-11-14 Thread Naoto Sato
On Sun, 14 Nov 2021 07:23:18 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed indentation > > src/java.base/share/classes/java/lang/System.java line 2123: > >> 2121: var jnuEncoding =

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v5]

2021-11-13 Thread Alan Bateman
On Sun, 14 Nov 2021 02:23:03 GMT, Naoto Sato wrote: >> Please review the subject fix. In light of JEP400, Java runtime can/should >> start in UTF-8 charset if the underlying native encoding is not supported. > > Naoto Sato has updated the pull request incrementally with one additional > commit

Re: RFR: 8275007: Java fails to start with null charset if LC_ALL is set to certain locales [v5]

2021-11-13 Thread Naoto Sato
> Please review the subject fix. In light of JEP400, Java runtime can/should > start in UTF-8 charset if the underlying native encoding is not supported. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Fixed indentation -