Re: RFR: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds [v3]

2021-10-25 Thread Jaikiran Pai
On Mon, 25 Oct 2021 08:04:43 GMT, Magnus Ihse Bursie wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> drop another final to make it consistent with rest of the code > >

Re: RFR: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds [v3]

2021-10-25 Thread Magnus Ihse Bursie
On Fri, 22 Oct 2021 10:44:31 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which fixes the issue reported in >> https://bugs.openjdk.java.net/browse/JDK-8275509? >> >> The `ModuleDescriptor.hashCode()` method uses the hash code of its various >> components to compute

Re: RFR: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds [v3]

2021-10-22 Thread Jaikiran Pai
> Can I please get a review for this change which fixes the issue reported in > https://bugs.openjdk.java.net/browse/JDK-8275509? > > The `ModuleDescriptor.hashCode()` method uses the hash code of its various > components to compute the final hash code. While doing so it ends up calling >