Re: RFR: 8276700: Improve java.lang.ref.Cleaner javadocs [v4]

2021-12-02 Thread Mandy Chung
On Wed, 10 Nov 2021 11:59:16 GMT, Hendrik Schreiber wrote: >> Trivial improvement. >> >> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`. >> Repeat (again) in the code example that the `State` `Runnable `should be >> implemented as static class and not reference

Re: RFR: 8276700: Improve java.lang.ref.Cleaner javadocs [v4]

2021-12-02 Thread Roger Riggs
On Wed, 10 Nov 2021 11:59:16 GMT, Hendrik Schreiber wrote: >> Trivial improvement. >> >> Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`. >> Repeat (again) in the code example that the `State` `Runnable `should be >> implemented as static class and not reference

Re: RFR: 8276700: Improve java.lang.ref.Cleaner javadocs [v4]

2021-11-10 Thread Hendrik Schreiber
On Wed, 10 Nov 2021 11:40:28 GMT, Anthony Vanelverdinghe wrote: >> This is getting too complicated... >> >> It's a code *example* with a very clear comment that explains a best >> practice: >> >> // A cleaner, preferably one shared within a library >> private static final Cleaner cleaner =

Re: RFR: 8276700: Improve java.lang.ref.Cleaner javadocs [v4]

2021-11-10 Thread Hendrik Schreiber
> Trivial improvement. > > Explicitly show how to create a `Cleaner` instance using `Cleaner.create()`. > Repeat (again) in the code example that the `State` `Runnable `should be > implemented as static class and not reference the instance to be cleaned, to > make the point even more clear to