Re: RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16 [v4]

2022-01-12 Thread Сергей Цыпанов
On Tue, 11 Jan 2022 13:53:58 GMT, Claes Redestad wrote: >> In `String.encodeUTF8_UTF16`, making the `char c` local to each loop helps >> the performance of the method by helping C2 optimize each individual loop >> better. >> >> Results on the updated micros: >> 19-b04: >> >> Benchmark

Re: RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16 [v4]

2022-01-11 Thread Claes Redestad
On Tue, 11 Jan 2022 12:58:51 GMT, Aleksey Shipilev wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Happy new year! > > Looks fine, consider touchups in benchmark code. Thanks for reviewing, @shipilev and

Re: RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16 [v4]

2022-01-11 Thread Claes Redestad
> In `String.encodeUTF8_UTF16`, making the `char c` local to each loop helps > the performance of the method by helping C2 optimize each individual loop > better. > > Results on the updated micros: > 19-b04: > > Benchmark (charsetName) Mode Cnt Score > Error

Re: RFR: 8279833: Loop optimization issue in String.encodeUTF8_UTF16 [v4]

2022-01-11 Thread Alan Bateman
On Tue, 11 Jan 2022 13:50:48 GMT, Claes Redestad wrote: >> In `String.encodeUTF8_UTF16`, making the `char c` local to each loop helps >> the performance of the method by helping C2 optimize each individual loop >> better. >> >> Results on the updated micros: >> 19-b04: >> >> Benchmark