On Fri, 21 Jan 2022 15:51:10 GMT, Michael McMahon wrote:
>> `NamingException` has `setRootCause()`. Why not use that? I use that one too
>> and full stack is retained.
>
> Yes, I can do that. Though it will cause the existing LDAP channel binding
> test to fail which is checking for an empty
On Fri, 21 Jan 2022 13:39:06 GMT, Michael Osipov wrote:
>> Actually, it turns out I should be throwing `NamingException` here. That is
>> what was being thrown by `TlsChannelBinding.parseType` before and an
>> existing test was expecting that. NamingException only takes a String
>> message.
On Fri, 21 Jan 2022 15:08:58 GMT, Michael McMahon wrote:
>> It was being handled elsewhere as "never". But, I agree it would be clearer
>> to normalise it to "never" here.
>
> Sorry, I should have checked back to the source rather than the snippet
> quoted. The problem is that the logError
On Fri, 21 Jan 2022 13:38:08 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/sun/net/www/http/HttpClient.java line 189:
>>
>>> 187: } else {
>>> 188: logError("Unexpected value for \"jdk.https.negotiate.cbt\"
>>> system property");
>>> 189: return s;
On Fri, 21 Jan 2022 13:35:53 GMT, Michael McMahon wrote:
>> src/java.naming/share/classes/com/sun/jndi/ldap/sasl/LdapSasl.java line 133:
>>
>>> 131:
>>> (String)env.get(TlsChannelBinding.CHANNEL_BINDING_TYPE));
>>> 132: } catch
On Thu, 20 Jan 2022 11:16:16 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
>
On Thu, 20 Jan 2022 11:14:40 GMT, Michael Osipov wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
>
On Thu, 20 Jan 2022 11:04:18 GMT, Daniel Fuchs wrote:
>> Michael McMahon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed sasl module dependency and added SaslException cause
>
>
On Thu, 20 Jan 2022 10:58:27 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Thu, 20 Jan 2022 10:58:27 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a CBT with authentication requests over Kerberos. The
11 matches
Mail list logo