Re: RFR: 8280459: Suspicious integer division in Hashtable.readHashtable

2022-01-24 Thread Aleksey Shipilev
On Fri, 21 Jan 2022 15:19:38 GMT, Aleksey Shipilev wrote: > Found by Sonar. See details in the bug. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` > - [x] Linux x86_64 fastdebug `java/util/Hashtable` Thanks for reviews! - PR: https://git.openjdk.java.net/jdk/pull

Re: RFR: 8280459: Suspicious integer division in Hashtable.readHashtable

2022-01-21 Thread Brian Burkhalter
On Fri, 21 Jan 2022 15:19:38 GMT, Aleksey Shipilev wrote: > Found by Sonar. See details in the bug. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` > - [x] Linux x86_64 fastdebug `java/util/Hashtable` Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk

Re: RFR: 8280459: Suspicious integer division in Hashtable.readHashtable

2022-01-21 Thread Roger Riggs
On Fri, 21 Jan 2022 15:19:38 GMT, Aleksey Shipilev wrote: > Found by Sonar. See details in the bug. > > Additional testing: > - [x] Linux x86_64 fastdebug `tier1` > - [x] Linux x86_64 fastdebug `java/util/Hashtable` LGTM. Seems reasonable though it might increase heap allocation of the array

RFR: 8280459: Suspicious integer division in Hashtable.readHashtable

2022-01-21 Thread Aleksey Shipilev
Found by Sonar. See details in the bug. Additional testing: - [x] Linux x86_64 fastdebug `tier1` - [x] Linux x86_64 fastdebug `java/util/Hashtable` - Commit messages: - Fix Changes: https://git.openjdk.java.net/jdk/pull/7178/files Webrev: https://webrevs.openjdk.java.net/?repo=j