On Tue, 22 Feb 2022 16:43:28 GMT, Daniel Jeliński wrote:
>> Please review this PR that enables
>> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170)
>> compiler flag, which makes assigning a string liter
On Tue, 22 Feb 2022 16:43:28 GMT, Daniel Jeliński wrote:
>> Please review this PR that enables
>> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170)
>> compiler flag, which makes assigning a string liter
On Tue, 22 Feb 2022 16:43:28 GMT, Daniel Jeliński wrote:
>> Please review this PR that enables
>> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170)
>> compiler flag, which makes assigning a string liter
On Tue, 22 Feb 2022 16:35:09 GMT, Magnus Ihse Bursie wrote:
>> Done
>
> Did you forget to push the fix?
Push works better when connected... this time it's pushed for real.
-
PR: https://git.openjdk.java.net/jdk/pull/7565
On Tue, 22 Feb 2022 14:13:43 GMT, Daniel Jeliński wrote:
>> make/autoconf/flags-cflags.m4 line 136:
>>
>>> 134: CFLAGS_WARNINGS_ARE_ERRORS="-WX"
>>> 135:
>>> 136: WARNINGS_ENABLE_ALL="-W3 -Zc:strictStrings"
>>
>> This is not strictly a flag to enable warnings. I'd recommend you mov
> Please review this PR that enables
> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170)
> compiler flag, which makes assigning a string literal to a non-const pointer
> a compile-time error.
>
> This t
