Re: RFR: 8283719: java/util/logging/CheckZombieLockTest.java failing intermittently [v3]

2022-04-08 Thread Alan Bateman
On Fri, 8 Apr 2022 17:20:36 GMT, Daniel Fuchs wrote: >> Please find enclosed a patch for >> `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently` >> >> My analysis is that the test fails intermittently because the `FileChannel` >> created by the test is garbage collected

Re: RFR: 8283719: java/util/logging/CheckZombieLockTest.java failing intermittently [v2]

2022-04-08 Thread Daniel Fuchs
On Fri, 8 Apr 2022 17:09:42 GMT, Alan Bateman wrote: > Looks fine, you can drop use of getAbsolutePath if you want to, not important > here. Done - used `File::toPath` since `lock` is a `File`. - PR: https://git.openjdk.java.net/jdk/pull/8168

Re: RFR: 8283719: java/util/logging/CheckZombieLockTest.java failing intermittently [v3]

2022-04-08 Thread Daniel Fuchs
> Please find enclosed a patch for > `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently` > > My analysis is that the test fails intermittently because the `FileChannel` > created by the test is garbage collected too early, which releases the > associated lock before the

Re: RFR: 8283719: java/util/logging/CheckZombieLockTest.java failing intermittently [v2]

2022-04-08 Thread Alan Bateman
On Fri, 8 Apr 2022 17:08:25 GMT, Daniel Fuchs wrote: >> Please find enclosed a patch for >> `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently` >> >> My analysis is that the test fails intermittently because the `FileChannel` >> created by the test is garbage collected

Re: RFR: 8283719: java/util/logging/CheckZombieLockTest.java failing intermittently [v2]

2022-04-08 Thread Daniel Fuchs
> Please find enclosed a patch for > `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently` > > My analysis is that the test fails intermittently because the `FileChannel` > created by the test is garbage collected too early, which releases the > associated lock before the

Re: RFR: 8283719: java/util/logging/CheckZombieLockTest.java failing intermittently [v2]

2022-04-08 Thread Daniel Fuchs
On Fri, 8 Apr 2022 16:50:45 GMT, Alan Bateman wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Incorporated review comments > > test/jdk/java/util/logging/CheckZombieLockTest.java line 247: > >> 245:

Re: RFR: 8283719: java/util/logging/CheckZombieLockTest.java failing intermittently

2022-04-08 Thread Alan Bateman
On Fri, 8 Apr 2022 16:37:07 GMT, Daniel Fuchs wrote: > Please find enclosed a patch for > `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently` > > My analysis is that the test fails intermittently because the `FileChannel` > created by the test is garbage collected too

RFR: 8283719: java/util/logging/CheckZombieLockTest.java failing intermittently

2022-04-08 Thread Daniel Fuchs
Please find enclosed a patch for `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently` My analysis is that the test fails intermittently because the `FileChannel` created by the test is garbage collected too early, which releases the associated lock before the `FileHandle