On Thu, 28 Apr 2022 19:48:18 GMT, Paul Sandoz wrote:
>> Jie Fu has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains six additional commits since
>> t
On Fri, 29 Apr 2022 06:35:44 GMT, Jie Fu wrote:
>> Hi all,
>>
>> The Current Vector API doc for `LSHR` is
>>
>> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>>
>>
>> This is misleading which may lead to bugs for Java developers.
>> This is because for negative byte/short elements, the results
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed by
> `LSHR` will be different from that of `>>>`.
On Thu, 28 Apr 2022 19:48:18 GMT, Paul Sandoz wrote:
>> Jie Fu has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains six additional commits since
>> t
On Thu, 28 Apr 2022 19:48:18 GMT, Paul Sandoz wrote:
> It should be possible for you finalize now.
Done.
Thanks @PaulSandoz .
-
PR: https://git.openjdk.java.net/jdk/pull/8291
On Wed, 27 Apr 2022 09:06:12 GMT, Jie Fu wrote:
>> Hi all,
>>
>> The Current Vector API doc for `LSHR` is
>>
>> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>>
>>
>> This is misleading which may lead to bugs for Java developers.
>> This is because for negative byte/short elements, the results
On Thu, 28 Apr 2022 00:08:41 GMT, Paul Sandoz wrote:
> I created one, filled it in, and assigned it to you (for other examples you
> can search in the issue tracker, this one quite is simple so i thought it was
> quicker to do myself to show you). For any specification change we need to
> revi
On Wed, 27 Apr 2022 09:06:12 GMT, Jie Fu wrote:
>> Hi all,
>>
>> The Current Vector API doc for `LSHR` is
>>
>> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>>
>>
>> This is misleading which may lead to bugs for Java developers.
>> This is because for negative byte/short elements, the results
On Wed, 27 Apr 2022 17:17:55 GMT, Paul Sandoz wrote:
> Thanks, looks good, we will need to create a CSR. Have you done that before?
No, and I don't know much about a CSR.
Is there any example for a doc fix CSR to follow?
Thanks.
-
PR: https://git.openjdk.java.net/jdk/pull/8291
On Wed, 27 Apr 2022 09:06:12 GMT, Jie Fu wrote:
>> Hi all,
>>
>> The Current Vector API doc for `LSHR` is
>>
>> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>>
>>
>> This is misleading which may lead to bugs for Java developers.
>> This is because for negative byte/short elements, the results
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed by
> `LSHR` will be different from that of `>>>`.
On Tue, 26 Apr 2022 21:41:37 GMT, Paul Sandoz wrote:
> After talking with John here's what we think is a better approach than what I
> originally had in mind:
>
> 1. In the class doc of `VectorOperators` add a definition for `EMASK`
> occurring after the definition for `ESIZE`:
>
> ```
> * {
On Thu, 21 Apr 2022 04:23:22 GMT, Jie Fu wrote:
>> Hi all,
>>
>> The Current Vector API doc for `LSHR` is
>>
>> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>>
>>
>> This is misleading which may lead to bugs for Java developers.
>> This is because for negative byte/short elements, the results
On Wed, 20 Apr 2022 17:24:56 GMT, Paul Sandoz wrote:
>> Hi all,
>>
>> The Current Vector API doc for `LSHR` is
>>
>> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>>
>>
>> This is misleading which may lead to bugs for Java developers.
>> This is because for negative byte/short elements, the res
On Wed, 20 Apr 2022 17:24:56 GMT, Paul Sandoz wrote:
> We can raise attention to that:
>
> ```
> /** Produce {@code a>>>(n&(ESIZE*8-1))}
> * (The operand and result are converted if the operand type is {@code byte}
> or {@code short}, see below). Integral only.
> * ...
> */
> ```
It s
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed by
> `LSHR` will be different from that of `>>>`.
On Tue, 19 Apr 2022 08:41:50 GMT, Jie Fu wrote:
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed
On Tue, 19 Apr 2022 08:41:50 GMT, Jie Fu wrote:
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed
On Wed, 20 Apr 2022 00:46:32 GMT, Paul Sandoz wrote:
> The intended pattern for the operator tokens is to present a short symbolic
> description using Java operators and common methods. It would be good to try
> and keep with this pattern, and clarify for the extra cases. Here's what i
> had i
On Tue, 19 Apr 2022 08:41:50 GMT, Jie Fu wrote:
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed
On Tue, 19 Apr 2022 16:11:37 GMT, Paul Sandoz wrote:
> I need to think a little more about this. The specification is not accurate
> and likely requires a CSR.
>
> My initial thoughts are I would prefer the operation to retain reference to
> the succinct definition using the logical right shif
On Tue, 19 Apr 2022 08:41:50 GMT, Jie Fu wrote:
> Hi all,
>
> The Current Vector API doc for `LSHR` is
>
> Produce a>>>(n&(ESIZE*8-1)). Integral only.
>
>
> This is misleading which may lead to bugs for Java developers.
> This is because for negative byte/short elements, the results computed
Hi all,
The Current Vector API doc for `LSHR` is
Produce a>>>(n&(ESIZE*8-1)). Integral only.
This is misleading which may lead to bugs for Java developers.
This is because for negative byte/short elements, the results computed by
`LSHR` will be different from that of `>>>`.
For more details, p
23 matches
Mail list logo
