On Wed, 27 Apr 2022 15:32:35 GMT, Roger Riggs wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update copyright, @bug list
>
> LGTM
Thanks for reviews @RogerRiggs and @mlchung
-
PR: https://git.openjdk
On Wed, 27 Apr 2022 18:25:27 GMT, Mandy Chung wrote:
>> That was my initial thought, but it doesn't work - CNSE is a checked
>> exception so must be handled.
>
>> test() and main will need to declare this checked exception.
>
>
> diff --git a/test/jdk/java/lang/ref/ReferenceClone.java
> b/tes
On Wed, 27 Apr 2022 18:19:57 GMT, Kim Barrett wrote:
>> test/jdk/java/lang/ref/ReferenceClone.java line 52:
>>
>>> 50: } catch (CloneNotSupportedException e) {
>>> 51: throw new RuntimeException("CloneableReference::clone
>>> should not throw CloneNotSupportedException");
>>
On Wed, 27 Apr 2022 15:57:34 GMT, Mandy Chung wrote:
>> Kim Barrett has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update copyright, @bug list
>
> test/jdk/java/lang/ref/ReferenceClone.java line 52:
>
>> 50: } catch (CloneNotSu
On Wed, 27 Apr 2022 10:11:15 GMT, Kim Barrett wrote:
>> Please review this fix to test/jdk/java/lang/ref/ReferenceClone.java. It was
>> passing if CloneableReference::clone were to throw
>> CloneNotSupportedException.
>> That should be a failure.
>>
>> Testing:
>> Locally (linux-x64) verified
On Wed, 27 Apr 2022 10:11:15 GMT, Kim Barrett wrote:
>> Please review this fix to test/jdk/java/lang/ref/ReferenceClone.java. It was
>> passing if CloneableReference::clone were to throw
>> CloneNotSupportedException.
>> That should be a failure.
>>
>> Testing:
>> Locally (linux-x64) verified
> Please review this fix to test/jdk/java/lang/ref/ReferenceClone.java. It was
> passing if CloneableReference::clone were to throw CloneNotSupportedException.
> That should be a failure.
>
> Testing:
> Locally (linux-x64) verified test still passes. Temporarily changed
> CloneableReference::clo
Please review this fix to test/jdk/java/lang/ref/ReferenceClone.java. It was
passing if CloneableReference::clone were to throw CloneNotSupportedException.
That should be a failure.
Testing:
Locally (linux-x64) verified test still passes. Temporarily changed
CloneableReference::clone to throw an
