Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v5]

2022-05-09 Thread Alan Bateman
On Sun, 8 May 2022 12:08:14 GMT, Doug Lea wrote: >> Changes ForkJoinPool.close spec and code to trap close as a no-op if called >> on common pool > > Doug Lea has updated the pull request incrementally with one additional > commit since the last revision: > > Test improvements Marked as rev

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v5]

2022-05-08 Thread Doug Lea
> Changes ForkJoinPool.close spec and code to trap close as a no-op if called > on common pool Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Test improvements - Changes: - all: https://git.openjdk.java.net/jdk/pull/8577

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v4]

2022-05-08 Thread Doug Lea
On Sun, 8 May 2022 01:51:17 GMT, Martin Buchholz wrote: >> Doug Lea has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - Accommodate restrictive SecurityManagers >> - merge with loom updates >>Merge remote-tracking branch 'refs/remot

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v4]

2022-05-07 Thread Martin Buchholz
On Sat, 7 May 2022 11:29:32 GMT, Doug Lea wrote: >> Changes ForkJoinPool.close spec and code to trap close as a no-op if called >> on common pool > > Doug Lea has updated the pull request incrementally with three additional > commits since the last revision: > > - Accommodate restrictive Secu

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v4]

2022-05-07 Thread Martin Buchholz
On Sat, 7 May 2022 11:29:32 GMT, Doug Lea wrote: >> Changes ForkJoinPool.close spec and code to trap close as a no-op if called >> on common pool > > Doug Lea has updated the pull request incrementally with three additional > commits since the last revision: > > - Accommodate restrictive Secu

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v4]

2022-05-07 Thread Martin Buchholz
On Sat, 7 May 2022 11:29:32 GMT, Doug Lea wrote: >> Changes ForkJoinPool.close spec and code to trap close as a no-op if called >> on common pool > > Doug Lea has updated the pull request incrementally with three additional > commits since the last revision: > > - Accommodate restrictive Secu

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v4]

2022-05-07 Thread Doug Lea
> Changes ForkJoinPool.close spec and code to trap close as a no-op if called > on common pool Doug Lea has updated the pull request incrementally with three additional commits since the last revision: - Accommodate restrictive SecurityManagers - merge with loom updates Merge remote-tracki

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v3]

2022-05-07 Thread Doug Lea
> Changes ForkJoinPool.close spec and code to trap close as a no-op if called > on common pool Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v2]

2022-05-06 Thread Doug Lea
On Fri, 6 May 2022 21:46:58 GMT, Martin Buchholz wrote: >> --- a/test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java >> +++ b/test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java >> @@ -55,7 +55,7 @@ public class ForkJoinPool19Test extends JSR166TestCase { >> } >> >> public

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v2]

2022-05-06 Thread Martin Buchholz
On Fri, 6 May 2022 21:28:45 GMT, Martin Buchholz wrote: >> Tests in this file are not being executed. I think you need: >> >> --- a/test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java >> +++ b/test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java >> @@ -55,7 +55,7 @@ public class Fork

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v2]

2022-05-06 Thread Martin Buchholz
On Fri, 6 May 2022 20:25:10 GMT, Martin Buchholz wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix doc types > > test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java line 496: > >> 494: >> 495: /** >> 496:

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v2]

2022-05-06 Thread Martin Buchholz
On Fri, 6 May 2022 21:27:53 GMT, Martin Buchholz wrote: >> test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java line 496: >> >>> 494: >>> 495: /** >>> 496: * Implictly closing a new pool using try-with-resources >>> terminates it >> >> Typo "Implictly" - twice > > Tests in this

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins [v2]

2022-05-06 Thread Doug Lea
> Changes ForkJoinPool.close spec and code to trap close as a no-op if called > on common pool Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Fix doc types - Changes: - all: https://git.openjdk.java.net/jdk/pull/8577/fil

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins

2022-05-06 Thread Martin Buchholz
On Fri, 6 May 2022 15:05:57 GMT, Doug Lea wrote: > Changes ForkJoinPool.close spec and code to trap close as a no-op if called > on common pool test/jdk/java/util/concurrent/tck/ForkJoinPool19Test.java line 496: > 494: > 495: /** > 496: * Implictly closing a new pool using try-with-r

Re: RFR: 8286294 : ForkJoinPool.commonPool().close() spins

2022-05-06 Thread Paul Sandoz
On Fri, 6 May 2022 15:05:57 GMT, Doug Lea wrote: > Changes ForkJoinPool.close spec and code to trap close as a no-op if called > on common pool Changes look good, it will need a CSR. - PR: https://git.openjdk.java.net/jdk/pull/8577

RFR: 8286294 : ForkJoinPool.commonPool().close() spins

2022-05-06 Thread Doug Lea
Changes ForkJoinPool.close spec and code to trap close as a no-op if called on common pool - Commit messages: - Override close as explicit no-op for common pool Changes: https://git.openjdk.java.net/jdk/pull/8577/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8577&ran