Re: RFR: 8287206: Use WrongThreadException for confinement errors

2022-05-25 Thread Uwe Schindler
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore wrote: > This patch tweaks the foreign API to use the newly added > `WrongThreadException` instead of `IllegalStateException` to report > confinement errors. I changed the PR on our side, `IllegalStateException` is fine, if you catch it a

Re: RFR: 8287206: Use WrongThreadException for confinement errors

2022-05-25 Thread Maurizio Cimadamore
On Wed, 25 May 2022 10:16:54 GMT, Maurizio Cimadamore wrote: > > Thinking more about it: `IllegalStateException` is fine for a closed > > `MemorySession`. If used by wrong thread the exception was indeed > > confusing. Now that the abiguity is gone, I can change our (Lucene) code > > and just

Re: RFR: 8287206: Use WrongThreadException for confinement errors

2022-05-25 Thread Maurizio Cimadamore
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore wrote: > This patch tweaks the foreign API to use the newly added > `WrongThreadException` instead of `IllegalStateException` to report > confinement errors. > Thinking more about it: `IllegalStateException` is fine for a closed > `Memory

Re: RFR: 8287206: Use WrongThreadException for confinement errors

2022-05-25 Thread Uwe Schindler
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore wrote: > This patch tweaks the foreign API to use the newly added > `WrongThreadException` instead of `IllegalStateException` to report > confinement errors. Thinking more about it: `IllegalStateException` is fine for a closed `MemorySess

Re: RFR: 8287206: Use WrongThreadException for confinement errors

2022-05-25 Thread Uwe Schindler
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore wrote: > This patch tweaks the foreign API to use the newly added > `WrongThreadException` instead of `IllegalStateException` to report > confinement errors. I have seen this PR now: Would it be also a good idea to replace the `IllegalSta

Re: RFR: 8287206: Use WrongThreadException for confinement errors

2022-05-24 Thread Mandy Chung
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore wrote: > This patch tweaks the foreign API to use the newly added > `WrongThreadException` instead of `IllegalStateException` to report > confinement errors. Marked as reviewed by mchung (Reviewer). - PR: https://git.openjdk.

Re: RFR: 8287206: Use WrongThreadException for confinement errors

2022-05-24 Thread Joe Darcy
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore wrote: > This patch tweaks the foreign API to use the newly added > `WrongThreadException` instead of `IllegalStateException` to report > confinement errors. Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.j

Re: RFR: 8287206: Use WrongThreadException for confinement errors

2022-05-24 Thread Alan Bateman
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore wrote: > This patch tweaks the foreign API to use the newly added > `WrongThreadException` instead of `IllegalStateException` to report > confinement errors. Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.j

Re: RFR: 8287206: Use WrongThreadException for confinement errors

2022-05-24 Thread Maurizio Cimadamore
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore wrote: > This patch tweaks the foreign API to use the newly added > `WrongThreadException` instead of `IllegalStateException` to report > confinement errors. javadoc: http://cr.openjdk.java.net/~mcimadamore/8287206/v1/javadoc/java.base/mo

RFR: 8287206: Use WrongThreadException for confinement errors

2022-05-24 Thread Maurizio Cimadamore
This patch tweaks the foreign API to use the newly added `WrongThreadException` instead of `IllegalStateException` to report confinement errors. - Commit messages: - Merge branch 'master' into wrong_thread_ex - Initial push Changes: https://git.openjdk.java.net/jdk/pull/8865/files