Re: RFR: Here are some easy patches

On Wed, May 2, 2018 at 2:43 PM, Michael Rasmussen < michael.rasmus...@roguewave.com> wrote: > But getComponentType itself calls isArray, so you are paying the native > method overhead anyway (though it is intrinsic). > Ohhh, I had forgotten I had looked at getComponentType earlier. So calling g

Re: RFR: Here are some easy patches

3 May 2018 00:13 To: Michael Rasmussen Cc: core-libs-dev Subject: Re: RFR: Here are some easy patches Michael, Thanks. This may be tricky. isArray is a native method, and we don't want to pay for native method overhead - we're depending on hotspot intrinsification. I suspect isArray

Re: RFR: Here are some easy patches

n Java 10, it improved the performance > with your test array (Object[10] full of Integers) from 244 us/op to > 160 us/op (vs current JDK: 399 us/op). > > > /Michael > -- > *From:* core-libs-dev on behalf > of Martin Buchholz > *Sent:* 02

Re: RFR: Here are some easy patches

: Here are some easy patches Hi Paul, On Mon, Apr 30, 2018 at 2:03 PM, Paul Sandoz wrote: > > > On Apr 30, 2018, at 11:18 AM, Martin Buchholz wrote: > > > > On Mon, Apr 30, 2018 at 10:35 AM, Paul Sandoz > wrote: > >> An obvious optimization: >> >>

Re: RFR: Here are some easy patches

Hi Paul, On Mon, Apr 30, 2018 at 2:03 PM, Paul Sandoz wrote: > > > On Apr 30, 2018, at 11:18 AM, Martin Buchholz wrote: > > > > On Mon, Apr 30, 2018 at 10:35 AM, Paul Sandoz > wrote: > >> An obvious optimization: >> >> 8202398: Optimize Arrays.deepHashCode >> http://cr.openjdk.java.net/~martin

Re: RFR: Here are some easy patches

> On Apr 30, 2018, at 11:18 AM, Martin Buchholz wrote: > > > > On Mon, Apr 30, 2018 at 10:35 AM, Paul Sandoz > wrote: >> An obvious optimization: >> >> 8202398: Optimize Arrays.deepHashCode >> http://cr.openjdk.java.net/~martin/webrevs/jdk/deepHashCode-optimiz

Re: RFR: Here are some easy patches

On Mon, Apr 30, 2018 at 10:35 AM, Paul Sandoz wrote: > An obvious optimization: > > 8202398: Optimize Arrays.deepHashCode > http://cr.openjdk.java.net/~martin/webrevs/jdk/deepHashCode-optimize/ > https://bugs.openjdk.java.net/browse/JDK-8202398 > > I would prefer that the deeply nested ternary ex

Re: RFR: Here are some easy patches

> On Apr 30, 2018, at 9:05 AM, Martin Buchholz wrote: > > Off by one pixel! > > 8202397: Typo in X-Buffer javadoc > http://cr.openjdk.java.net/~martin/webrevs/jdk/X-Buffer-typo/ > > https://bugs.openjdk.java.net/browse/JDK-820239

RFR: Here are some easy patches

Off by one pixel! 8202397: Typo in X-Buffer javadoc http://cr.openjdk.java.net/~martin/webrevs/jdk/X-Buffer-typo/ https://bugs.openjdk.java.net/browse/JDK-8202397 Fixes a long-term micro-embarrassment: 8201634: Random seedUniquifier uses incorrect LCG http://cr.openjdk.java.net/~martin/webrevs/j