Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread David Holmes
On 19/10/2013 1:15 AM, Volker Simonis wrote: Hi Erik, I had to fix another issue in the JAXWS build (https://bugs.openjdk.java.net/browse/JDK-8026874) but with that I've finally managed to get to the Corba build with a J9 bootstrap JDK. With the following small change in BuildCorba.gmk: -

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread David Holmes
On 19/10/2013 1:50 AM, Erik Joelsson wrote: Hello Volker, Building without a -bootclasspath results in the following warning which is likely why it was added in the first place: warning: [options] bootstrap class path not set in conjunction with -source 1.7 Note that we are using the

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread Volker Simonis
On Mon, Oct 21, 2013 at 9:02 AM, David Holmes david.hol...@oracle.com wrote: On 19/10/2013 1:15 AM, Volker Simonis wrote: Hi Erik, I had to fix another issue in the JAXWS build (https://bugs.openjdk.java.net/browse/JDK-8026874) but with that I've finally managed to get to the Corba build

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread Volker Simonis
Hi Erik, with the small changes proposed in 8026964: Building with an IBM J9 boot jdk requires special settings for BOOT_RTJAR https://bugs.openjdk.java.net/browse/JDK-8026964 I could finally successfully build with J9 as bootstrap jdk. I saw that you already submitted this change so I'm

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-21 Thread Volker Simonis
Hi Neil, Steve, is there an easy way to detect and specify a correct setting for $(BOOT_RTJAR) if we are using an IBM J9 as bootstrap jdk in the new build system? With OpenJDK/Oracle based boot jdks $(BOOT_RTJAR) is simply set to $BOOT_JDK/jre/lib/rt.jar but this doesn't work with IBM J9 because

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-18 Thread Erik Joelsson
Hello Volker, Building without a -bootclasspath results in the following warning which is likely why it was added in the first place: warning: [options] bootstrap class path not set in conjunction with -source 1.7 Note that we are using the bootstrap javac, so it's not the one bundled

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-16 Thread Erik Joelsson
New webrev: http://cr.openjdk.java.net/~erikj/6604021/webrev.02/ * Changed Node.java as David suggested. * Added comment suggested by Martin to Setup.gmk, where the compiler setup is done. Couldn't think of a better place. * Changed comment in JavaCompilation. A note on Corba. While the corba

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-16 Thread Erik Joelsson
On 2013-10-15 17:29, Volker Simonis wrote: Hi Erik, Alan, first of all I think this is a good change because it helps porters to build a complete JDK even if the newly build rmic wouldn't run. On the other hand I'm a little bit concerned if this change still allows it to bootstrap with a

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-16 Thread David Holmes
Ship it! Quickly! :) Thanks, David On 16/10/2013 8:19 PM, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/6604021/webrev.02/ * Changed Node.java as David suggested. * Added comment suggested by Martin to Setup.gmk, where the compiler setup is done. Couldn't think of a

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-16 Thread Chris Hegarty
On 16/10/2013 11:35, David Holmes wrote: Ship it! Quickly! :) +1 looks good to me. Thanks Erik, -Chris. Thanks, David On 16/10/2013 8:19 PM, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/6604021/webrev.02/ * Changed Node.java as David suggested. * Added comment

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-16 Thread Alan Bateman
On 16/10/2013 01:04, David Holmes wrote: I think API restrictions already apply to the sun.tools packages - and both language and API restrictions apply to other build tools that are compiled using the boot JDK. Yes for build tools but not sun.tools.** in general (the change to

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-16 Thread Volker Simonis
On Wed, Oct 16, 2013 at 12:22 PM, Erik Joelsson erik.joels...@oracle.com wrote: On 2013-10-15 17:29, Volker Simonis wrote: Hi Erik, Alan, first of all I think this is a good change because it helps porters to build a complete JDK even if the newly build rmic wouldn't run. On the other

RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-15 Thread Erik Joelsson
Currently the RMI stubs in the jdk are built with the newly built rmic binary at the end of the build. This patch changes that and instead builds a bootstrap version of the rmic classes, much like bootstrap javac in langtools, which runs on the bootjdk, but generates classes for the new jdk.

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-15 Thread Alan Bateman
On 15/10/2013 15:30, Erik Joelsson wrote: Currently the RMI stubs in the jdk are built with the newly built rmic binary at the end of the build. This patch changes that and instead builds a bootstrap version of the rmic classes, much like bootstrap javac in langtools, which runs on the

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-15 Thread Erik Joelsson
On 2013-10-15 16:40, Alan Bateman wrote: On 15/10/2013 15:30, Erik Joelsson wrote: Currently the RMI stubs in the jdk are built with the newly built rmic binary at the end of the build. This patch changes that and instead builds a bootstrap version of the rmic classes, much like bootstrap

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-15 Thread Volker Simonis
Hi Erik, Alan, first of all I think this is a good change because it helps porters to build a complete JDK even if the newly build rmic wouldn't run. On the other hand I'm a little bit concerned if this change still allows it to bootstrap with a non-Oracle based bootstrap JDK. I remember that we

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-15 Thread David Holmes
Hi Erik, Many thanks for jumping on this! On 16/10/2013 12:30 AM, Erik Joelsson wrote: Currently the RMI stubs in the jdk are built with the newly built rmic binary at the end of the build. This patch changes that and instead builds a bootstrap version of the rmic classes, much like bootstrap

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-15 Thread David Holmes
On 16/10/2013 12:40 AM, Alan Bateman wrote: On 15/10/2013 15:30, Erik Joelsson wrote: Currently the RMI stubs in the jdk are built with the newly built rmic binary at the end of the build. This patch changes that and instead builds a bootstrap version of the rmic classes, much like bootstrap

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-15 Thread David Holmes
Hi Volker, On 16/10/2013 1:29 AM, Volker Simonis wrote: Hi Erik, Alan, first of all I think this is a good change because it helps porters to build a complete JDK even if the newly build rmic wouldn't run. On the other hand I'm a little bit concerned if this change still allows it to

Re: RFR: JDK-6604021: RMIC is defaulting to BOOT jdk version, needs to be rmic.jar

2013-10-15 Thread David Holmes
On 16/10/2013 10:02 AM, David Holmes wrote: Hi Erik, Many thanks for jumping on this! On 16/10/2013 12:30 AM, Erik Joelsson wrote: Currently the RMI stubs in the jdk are built with the newly built rmic binary at the end of the build. This patch changes that and instead builds a bootstrap