Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

On 03/06/2015 02:30 PM, Staffan Larsen wrote: I would like to backport this bug fix to jdk8 - does anyone see any problems with that? The patch applies cleanly (after shuffling) and the java/lang/invoke/ tests succeed. Thanks, /Staffan I see no problem, quite the opposite, please backport i

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

I would like to backport this bug fix to jdk8 - does anyone see any problems with that? The patch applies cleanly (after shuffling) and the java/lang/invoke/ tests succeed. Thanks, /Staffan

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

1. Are there other places where we generate ACC_SYNTHETIC that should also get @Hidden annotations? Compiler-generated bridge methods?

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

I think this work (which is good) underlines a general there for some kind of pluggable logic for converting a synthetic method name into something more useful for the reader and/or to manipulate stack trace elements (i.e. remove elements, fold 2-3 elements into a new one, etc.). Lambda methods

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

On 02/17/2015 07:54 AM, John Rose wrote: On Feb 16, 2015, at 10:33 PM, Staffan Larsen wrote: The first shot at fixing this bug was to filter out ACC_SYNTHETIC. The drawback was that the actual lambda method are marked ACC_SYNTHETIC, so that filtered too much. OTOH it seems odd to filter out

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

On 02/17/2015 07:54 AM, John Rose wrote: On Feb 16, 2015, at 10:33 PM, Staffan Larsen wrote: The first shot at fixing this bug was to filter out ACC_SYNTHETIC. The drawback was that the actual lambda method are marked ACC_SYNTHETIC, so that filtered too much. OTOH it seems odd to filter out

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

On Feb 16, 2015, at 10:33 PM, Staffan Larsen wrote: > > The first shot at fixing this bug was to filter out ACC_SYNTHETIC. The > drawback was that the actual lambda method are marked ACC_SYNTHETIC, so that > filtered too much. OTOH it seems odd to filter out the actual interface method. Idea

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

> On 17 feb 2015, at 02:16, John Rose wrote: > > On Feb 16, 2015, at 6:25 AM, Staffan Larsen > wrote: >> >> new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.02/ >> > Looks good; ship it. Thanks.

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

On Feb 16, 2015, at 6:25 AM, Staffan Larsen wrote: > > new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.02/ > Looks good; ship it. To me this fix raises more questions: 1. Are there other places where we generate ACC_SYNTHETIC that

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

yes, thumb up ! Rémi Le 16 février 2015 18:50:25 CET, "Joel Borggrén-Franck" a écrit : >+1 > >cheers >/Joel > >> On 16 Feb 2015, at 15:25, Staffan Larsen >wrote: >> >> Good point! >> >> new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.02/ >> >> Thanks, >> /Staffan >> >>> On 16 f

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

+1 cheers /Joel > On 16 Feb 2015, at 15:25, Staffan Larsen wrote: > > Good point! > > new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.02/ > > Thanks, > /Staffan > >> On 16 feb 2015, at 12:40, Remi Forax wrote: >> >> Hi Staffan, >> ASM MethodVisitor API requires to call visitAnno

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

Good point! new webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.02/ Thanks, /Staffan > On 16 feb 2015, at 12:40, Remi Forax wrote: > > Hi Staffan, > ASM MethodVisitor API requires to call visitAnnotation before calling > visitCode s

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

Looks good. Best regards, Vladimir Ivanov On 2/16/15 10:47 AM, Staffan Larsen wrote: Brian pointed out to me that this change missed to add the annotation to bridge methods. Here is an updated version that takes those into account. I also needed to update the test to verify that bridge method

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

Brian pointed out to me that this change missed to add the annotation to bridge methods. Here is an updated version that takes those into account. I also needed to update the test to verify that bridge methods were correctly annotated - it got a little bit more complex since I had to force bridg

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

Hi, > On 03 Feb 2015, at 10:15, Staffan Larsen wrote: > > Hi, > > Please review this patch for hiding the lambda proxy frame in stack traces: > > bug: https://bugs.openjdk.java.net/browse/JDK-8025636 > webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.00/ > > This is a straightforward ad

Re: RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

Looks good for me. Rémi Le 3 février 2015 10:15:24 CET, Staffan Larsen a écrit : >Hi, > >Please review this patch for hiding the lambda proxy frame in stack >traces: > >bug: https://bugs.openjdk.java.net/browse/JDK-8025636 > >webrev: http://cr.

RFR: JDK-8025636 Hide lambda proxy frames in stacktraces

Hi, Please review this patch for hiding the lambda proxy frame in stack traces: bug: https://bugs.openjdk.java.net/browse/JDK-8025636 webrev: http://cr.openjdk.java.net/~sla/8025636/webrev.00/