Re: RFR: JDK-8035870 - Check jdk/src/windows/native/java/io/WinNTFileSystem_md.c for JNI pending exceptions

2014-03-13 Thread Chris Hegarty
Looks good to me Mark. -Chris. On 12 Mar 2014, at 17:39, Mark Sheppard mark.shepp...@oracle.com wrote: Hi please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8035870/webrev/ which address the issues raised in

RFR: JDK-8035870 - Check jdk/src/windows/native/java/io/WinNTFileSystem_md.c for JNI pending exceptions

2014-03-12 Thread Mark Sheppard
Hi please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8035870/webrev/ which address the issues raised in https://bugs.openjdk.java.net/browse/JDK-8035870 summary: checks to return values from malloc added with appropriate JNU_ThrowOutOfMemoryError added

Re: RFR: JDK-8035870 - Check jdk/src/windows/native/java/io/WinNTFileSystem_md.c for JNI pending exceptions

2014-03-12 Thread Alan Bateman
On 12/03/2014 17:39, Mark Sheppard wrote: Hi please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8035870/webrev/ This looks okay me. It looks like the errno=ENOMEM at line 638 can be removed as part of this. -Alan.