Hi Sherman,
Looks ok.
Thanks, Roger
On 6/16/2014 1:00 PM, Xueming Shen wrote:
OK, let's go the non-controversial approach. The webrev has been
updated to simply remove
those redundant/duplicated class files from the builder and use the
updated version of the tzdb
builder.
OK, let's go the non-controversial approach. The webrev has been updated to
simply remove
those redundant/duplicated class files from the builder and use the updated
version of the tzdb
builder.
http://cr.openjdk.java.net/~sherman/8042369/webrev
Thanks!
-Sherman
On 5/20/2014 1:52 PM, roger
Masayoshi, Roger,
OK, let's forget the fancy TarInputStream for now:-)
Here is the webrev that just updates the code to use existing java.time classes
for tzdb data building.
http://cr.openjdk.java.net/~sherman/8042369/webrev
The difference compared to the last version [1] is that it reads in
Hi Sherman,
Even though it has well defined content, checking in the tar.gz seems
not quite right.
Can the tests reconstruct the tar file from the contents or directly use
the IANA data on demand from the IANA site?
From a maintenance point of view, functions added to the JDK should be
well
Hi,
I've not got any feedback so far, so I assume it's good:-)
Anyway, I'm going a little further to throw in a TarInputStream so now we just
build the
tzdb data directly on the tzdata201xy.tar.gz from iana site. I'm not sure if
it is OK to
check in the original .tar.gz file into the jdk
Hi
Please help review the change for #8042369
Issue: https://bugs.openjdk.java.net/browse/JDK-8042369
Webrev: http://cr.openjdk.java.net/~sherman/8042369/webrev
In jdk8 we had to duplicate dozen java.time classes in build.tools to build the
timezone data
for the new JSR310 timezone data
