Re: RFR: JDK-8057556: JDP should better handle non-active interfaces

2014-09-08 Thread Yasumasa Suenaga
Hi Jaroslav, I could not receive your email. So I reply from another email. L103 Please, move "else" to the previous line I will fix it. L96-100 Do we still need these lines? Isn't `channel.setOption(StandardSocketOptions.IP_MULTICAST_IF, interf);` enough to listen on the interface? I thi

Re: RFR: JDK-8057556: JDP should better handle non-active interfaces

2014-09-06 Thread dmitry . samersoff
Please, file a separate issue. --Dmitry -Original Message- From: Yasumasa Suenaga To: Peter Allwin Cc: Dmitry Samersoff , "core-libs-dev@openjdk.java.net" , "serviceability-...@openjdk.java.net" Sent: Sat, 06 Sep 2014 19:37 Subject: Re: RFR: JDK-8057556: JDP

Re: RFR: JDK-8057556: JDP should better handle non-active interfaces

2014-09-06 Thread Yasumasa Suenaga
Hi all, My patch works fine in my environment, however, JMX agent will be terminated silently when I run command as following: java -Dcom.sun.management.jmxremote.port=7091 -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxr

Re: RFR: JDK-8057556: JDP should better handle non-active interfaces

2014-09-05 Thread Yasumasa Suenaga
Hi Peter, I fixed it and created new webrev. http://cr.openjdk.java.net/~ysuenaga/JDK-8057556/webrev.1/ Could you review it again? Thanks, Yasumasa (2014/09/05 17:20), Peter Allwin wrote: Looks like only the first Interface will be considered if no srcAddress is provided (succeeded will b

Re: RFR: JDK-8057556: JDP should better handle non-active interfaces

2014-09-05 Thread Peter Allwin
Looks like only the first Interface will be considered if no srcAddress is provided (succeeded will be false and we will throw to exit the while loop). Is this intended? Thanks! /peter > On 4 sep 2014, at 17:59, Yasumasa Suenaga wrote: > > Hi all, > > Thank you so much, Dmitry! > > I've cre

Re: RFR: JDK-8057556: JDP should better handle non-active interfaces

2014-09-04 Thread Dmitry Samersoff
Looks good for me! On 2014-09-04 19:59, Yasumasa Suenaga wrote: > Hi all, > > Thank you so much, Dmitry! > > I've created webrev for it. > http://cr.openjdk.java.net/~ysuenaga/JDK-8057556/webrev.0/ > > Please review. > > > Thanks, > > Yasumasa > > > (2014/09/04 21:26), Dmitry Samersoff wro

RFR: JDK-8057556: JDP should better handle non-active interfaces

2014-09-04 Thread Yasumasa Suenaga
Hi all, Thank you so much, Dmitry! I've created webrev for it. http://cr.openjdk.java.net/~ysuenaga/JDK-8057556/webrev.0/ Please review. Thanks, Yasumasa (2014/09/04 21:26), Dmitry Samersoff wrote: > Yasumasa, > > The CR number is JDK-8057556 > > I'll care about it's integration. > > -Dm