Re: RFR: JDK-8211071: unpack.cpp fails to compile with statement has no effect [-Werror=unused-value]

Hi Christoph & Magnus, thanks for reviewing! Am 27.09.18 um 08:22 schrieb Langer, Christoph: > Hi Roman, > > this looks good to me. +1 > > Best regards > Christoph > >> -Original Message- >> From: build-dev On Behalf Of >> Roman Kennke >> Sent: Mittwoch, 26. September 2018 19:24 >>

RE: RFR: JDK-8211071: unpack.cpp fails to compile with statement has no effect [-Werror=unused-value]

Hi Roman, this looks good to me. +1 Best regards Christoph > -Original Message- > From: build-dev On Behalf Of > Roman Kennke > Sent: Mittwoch, 26. September 2018 19:24 > To: Magnus Ihse Bursie ; core-libs- > d...@openjdk.java.net > Cc: build-...@openjdk.java.net > Subject: Re: RFR:

Re: RFR: JDK-8211071: unpack.cpp fails to compile with statement has no effect [-Werror=unused-value]

Ping core-libs? Roman Am 25.09.18 um 11:06 schrieb Magnus Ihse Bursie: > >> 25 sep. 2018 kl. 10:21 skrev Roman Kennke : >> >> Not sure this is the correct list. Please redirect as appropriate. > > I believe core-libs is the appropriate place. Cc:d. > >> >> Please review the following

Re: RFR: JDK-8211071: unpack.cpp fails to compile with statement has no effect [-Werror=unused-value]

> 25 sep. 2018 kl. 10:21 skrev Roman Kennke : > > Not sure this is the correct list. Please redirect as appropriate. I believe core-libs is the appropriate place. Cc:d. > > Please review the following proposed change: > > > There are 3 asserts in unpack.cpp which check only constants, and