Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation (update 2)

On 1/27/2019 4:55 AM, Alan Bateman wrote: On 11/01/2019 19:41, Andy Herrick wrote: This is the second update to the Request For Review of the implementation of the Java Packager Tool (jpackager) as described in JEP 343: Packaging Tool I've

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation (update 2)

On 11/01/2019 19:41, Andy Herrick wrote: This is the second update to the Request For Review of the implementation of the Java Packager Tool (jpackager) as described in JEP 343: Packaging Tool I've started to play with the latest EA build,

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation (update 2)

On 2019-01-17 16:06, Andy Herrick wrote: If I remove the line -nologo from lib-jdk.jpackage.gmk: 69 LDFLAGS_windows := -nologo, \ I get the logo during build (same with console andnon-console version): Microsoft (R) Incremental Linker Version 14.12.25835.0 Copyright (C) Microsoft

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation (update 2)

If I remove the line -nologo from lib-jdk.jpackage.gmk: 69 LDFLAGS_windows := -nologo, \ I get the logo during build (same with console andnon-console version): Microsoft (R) Incremental Linker Version 14.12.25835.0 Copyright (C) Microsoft Corporation.  All rights reserved. do I need

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation (update 2)

Hi Andy, This is looking really sweet from a build perspective! Just a few minor nits: * In Launcher-jdk.jpackage.gmk, please indent the else clause ("$(eval $(call SetupBuildLauncher, jpackage ") two spaces. * In Lib-jdk.jpackage.gmk, I think there's still room to prune some more

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation (update 2)

yes On 1/13/2019 2:50 PM, Alan Bateman wrote: On 11/01/2019 19:41, Andy Herrick wrote: This is the second update to the Request For Review of the implementation of the Java Packager Tool (jpackager) as described in JEP 343: Packaging Tool

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation (update 2)

On 11/01/2019 19:41, Andy Herrick wrote: This is the second update to the Request For Review of the implementation of the Java Packager Tool (jpackager) as described in JEP 343: Packaging Tool You're making great progress. Is the table of CLI

RFR: JDK-8212780: JEP 343: Packaging Tool Implementation (update 2)

This is the second update to the Request For Review of the implementation of the Java Packager Tool (jpackager) as described in JEP 343: Packaging Tool This webrev corresponds to the second EA build, Build 8 (2019/1/8), posted at