On 2019-02-01 23:38, Alexander Matveev wrote:
Hi Magnus,
http://cr.openjdk.java.net/~almatvee/8217317/webrev.01/
Looks great, thank you!
I can't comment on the actual source code changes, so you'll need a
thumbs up from someone in core libs as well.
Moved files to libjpackage and remove
looks good.
/Andy
On 2/1/2019 5:38 PM, Alexander Matveev wrote:
Hi Magnus,
http://cr.openjdk.java.net/~almatvee/8217317/webrev.01/
Moved files to libjpackage and remove JPACKAGELIB_SRC.
Old wmain() was in jpackage.cpp line 461.
Thanks,
Alexander
On 2/1/2019 3:39 AM, Magnus Ihse Bursie
Hi Magnus,
http://cr.openjdk.java.net/~almatvee/8217317/webrev.01/
Moved files to libjpackage and remove JPACKAGELIB_SRC.
Old wmain() was in jpackage.cpp line 461.
Thanks,
Alexander
On 2/1/2019 3:39 AM, Magnus Ihse Bursie wrote:
Hi Alexander,
On 2019-02-01 05:22, Alexander Matveev wrote:
This looks good once Magnus's concerns are addressed.
/Andy
On 2/1/2019 6:39 AM, Magnus Ihse Bursie wrote:
Hi Alexander,
On 2019-02-01 05:22, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
Hi Alexander,
On 2019-02-01 05:22, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- jpackage launcher will now build same as Linux and OS X using
SetupBuildLauncher.
-
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- jpackage launcher will now build same as Linux and OS X using
SetupBuildLauncher.
- jpackage.dll was added based on Windows jpackage.exe launcher
