On 1/30/2019 6:46 PM, Mandy Chung wrote:
On 1/30/19 2:05 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8217792 : Investigate what modules are included
For modules i
On 1/30/19 2:05 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8217792 : Investigate what modules are included
For modules included in the runtime of a non-modular appli
yes - I will put the else back - no impact on functionality (both can't
be true), but it reads better with the else, conforms to the coding
style, and could be minutely faster.
/Andy
On 1/30/2019 5:40 PM, Alexander Matveev wrote:
Hi Andy,
http://cr.openjdk.java.net/~herrick/8217792/webrev.0
Looks good.
-- Kevin
On 1/30/2019 2:05 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8217792 : Investigate what modules are included
For modules included in the runt
Hi Andy,
http://cr.openjdk.java.net/~herrick/8217792/webrev.03/src/jdk.jpackage/share/classes/jdk/jpackage/internal/JLinkBundlerHelper.java.frames.html
Line 272: Did you mean "if" here? I think it should be changed back to
"else if".
Otherwise looks fine.
Thanks,
Alexander
On 1/30/2019 2:05
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
JDK-8217792 : Investigate what modules are included
For modules included in the runtime of a non-modular application, we now
computes all modules that
