Hi Andy,
Looks good. As well as other fixes you send yesterday for review.
Thanks,
Alexander
On 6/6/2019 12:48 PM, Andy Herrick wrote:
OK - revised MacCertificate as per below:
webrev: http://cr.openjdk.java.net/~herrick/822/webrev.03
/Andy
On 6/6/2019 12:47 PM, Alexey Semenyuk wrote:
Looks good.
- Alexey
On 6/6/2019 3:48 PM, Andy Herrick wrote:
OK - revised MacCertificate as per below:
webrev: http://cr.openjdk.java.net/~herrick/822/webrev.03
/Andy
On 6/6/2019 12:47 PM, Alexey Semenyuk wrote:
OK - revised MacCertificate as per below:
webrev: http://cr.openjdk.java.net/~herrick/822/webrev.03
/Andy
On 6/6/2019 12:47 PM, Alexey Semenyuk wrote:
http://cr.openjdk.java.net/~herrick/822/webrev.02/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacCertificate.java.sdiff.html,
http://cr.openjdk.java.net/~herrick/822/webrev.02/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacCertificate.java.sdiff.html,
lines 81-93 can be replaced with a single statement, something like:
---
java.nio.file.Files.copy(
new ByteArrayInputStream(baos.toByteArray()),
,
Rémi
- Mail original -
De: "Andy Herrick"
À: "core-libs-dev"
Envoyé: Jeudi 6 Juin 2019 01:54:05
Objet: RFR: JDK-8223333: Use try-with-resources where feasible
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sa
a java.nio.file.Path instead a java.nio.File.
regards,
Rémi
- Mail original -
> De: "Andy Herrick"
> À: "core-libs-dev"
> Envoyé: Jeudi 6 Juin 2019 01:54:05
> Objet: RFR: JDK-8223333: Use try-with-resources where feasible
> Please review the jpackage fix for
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-822
[2] http://cr.openjdk.java.net/~herrick/822/
/Andy
