Re: RFR: JDK-8225249: LinuxDebBundler and LinuxRpmBundler should share more

2019-09-23 Thread Andy Herrick
This looks good far as I can tell. /Andy On 9/18/2019 11:23 AM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This fix: - Move common deb and rpm packaging code in the

Re: RFR: JDK-8225249: LinuxDebBundler and LinuxRpmBundler should share more

2019-09-18 Thread Alexander Matveev
Hi Alexey, Looks good. Thanks, Alexander On 9/18/2019 8:23 AM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This fix: - Move common deb and rpm packaging code in the

RFR: JDK-8225249: LinuxDebBundler and LinuxRpmBundler should share more

2019-09-18 Thread Alexey Semenyuk
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This fix: - Move common deb and rpm packaging code in the new class (jdk.jpackage.internal.LinuxPackageBundler). - Implement Java runtime packaging