Re: RFR: JDK-8226751: "Exception: ..." for missing file

Looks good. On 7/1/2019 11:12 AM, Alexey Semenyuk wrote: Looks good. On 7/1/2019 1:07 PM, Andy Herrick wrote: Updated webrev at https://bugs.openjdk.java.net/browse/JDK-8226751/webrev.02 to use Files.isReadable() /Andy On 6/29/2019 9:54 AM, Kevin Rushforth wrote: The rest of the CommandLi

Re: RFR: JDK-8226751: "Exception: ..." for missing file

Looks good. On 7/1/2019 1:07 PM, Andy Herrick wrote: Updated webrev at https://bugs.openjdk.java.net/browse/JDK-8226751/webrev.02 to use Files.isReadable() /Andy On 6/29/2019 9:54 AM, Kevin Rushforth wrote: The rest of the CommandLine class uses nio Paths/Files, so the following might be a

Re: RFR: JDK-8226751: "Exception: ..." for missing file

Updated webrev at https://bugs.openjdk.java.net/browse/JDK-8226751/webrev.02 to use Files.isReadable() /Andy On 6/29/2019 9:54 AM, Kevin Rushforth wrote: The rest of the CommandLine class uses nio Paths/Files, so the following might be a better fit, and also checks whether the file can be r

Re: RFR: JDK-8226751: "Exception: ..." for missing file

The rest of the CommandLine class uses nio Paths/Files, so the following might be a better fit, and also checks whether the file can be read:     if (!Files.isReadable(Paths.of(name))) The rest looks fine. -- Kevin On 6/29/2019 6:27 AM, Andy Herrick wrote: Please review the jpackage fix for

RFR: JDK-8226751: "Exception: ..." for missing file

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226751 [2] http://cr.openjdk.java.net/~herrick/8226751/