Looks good.
Thanks,
Alexander
On 9/12/2019 4:11 AM, Andy Herrick wrote:
Revised with webrev.03.
Changed SimplePackageTest instructions as suggested and added
LinuxDebBundler.java to file list (double checked file list used to
create webrev contains all changed files).
/ANdy
On 9/11/2019
Looks good.
Would you mind creating a follow up CR to add jtreg test(s) for the new
command line option.
- Alexey
On 9/12/2019 7:11 AM, Andy Herrick wrote:
Revised with webrev.03.
Changed SimplePackageTest instructions as suggested and added
LinuxDebBundler.java to file list (double
Revised with webrev.03.
Changed SimplePackageTest instructions as suggested and added
LinuxDebBundler.java to file list (double checked file list used to
create webrev contains all changed files).
/ANdy
On 9/11/2019 10:09 PM, Alexey Semenyuk wrote:
SimplePackageTest.java:
I'd suggest to
SimplePackageTest.java:
I'd suggest to put "Installer should not create any shortcuts" in the
description or simply remove notice about shortcuts.
Did you omit adding shortcuts to LinuxDebBundler.java on purpose?
- Alexey
On 9/11/2019 9:07 PM, Andy Herrick wrote:
Please review the jpackage
Looks good.
On 9/11/2019 6:07 PM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
1.) adds the new option --linux-shortcut, and now only creates a
shortcut on linux
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
This fix:
1.) adds the new option --linux-shortcut, and now only creates a
shortcut on linux if specified
2.) only creates a shortcut on windows if
