Re: RFR: JDK-8229840: Add jtreg test for --linux-app-category option

2019-09-04 Thread Andy Herrick
looks ok /Andy On 8/30/2019 5:55 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - added jtreg test for --linux-app-category option; - added jtreg test for

Re: RFR: JDK-8229840: Add jtreg test for --linux-app-category option

2019-08-30 Thread Alexey Semenyuk
On 8/30/2019 7:15 PM, Alexander Matveev wrote: Hi Alexey, Looks good. Any plans to convert all tests to use new helper classes? Yes, of course! I plan to do this is steps: 1. Refactor Linux tests; 2. Refactor Windows tests; 3. Refactor OSX tests; I'll cover steps 1 and 2 myself once I sort

Re: RFR: JDK-8229840: Add jtreg test for --linux-app-category option

2019-08-30 Thread Alexander Matveev
Hi Alexey, Looks good. Any plans to convert all tests to use new helper classes? Thanks, Alexander On 8/30/2019 2:55 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). -

RFR: JDK-8229840: Add jtreg test for --linux-app-category option

2019-08-30 Thread Alexey Semenyuk
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - added jtreg test for --linux-app-category option; - added jtreg test for --linux-release option; This is to address [3] issue; - introduced helper